Bug 207910

Summary: results.webkit.org: Correctly report JSC tests for windows
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, commit-queue, dbates, ews-watchlist, webkit-bug-importer, zhifei_fang
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2020-02-18 14:05:44 PST
We aren't setting the version number and version name for JSC testing correctly.
Attachments
Patch (1.77 KB, patch)
2020-02-18 14:22 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.74 KB, patch)
2020-02-19 07:38 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2020-02-18 14:22:57 PST
Created attachment 391092 [details] Patch
Aakash Jain
Comment 2 2020-02-18 14:26:05 PST
Comment on attachment 391092 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391092&action=review rs=me > Tools/Scripts/webkitdirs.pm:1372 > + $versionString =~ /(\d+)\.(\d+)\.(\d+)/; what does versionString looks like on windows?
Jonathan Bedard
Comment 3 2020-02-18 14:47:53 PST
(In reply to Aakash Jain from comment #2) > Comment on attachment 391092 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391092&action=review > > rs=me > > > Tools/Scripts/webkitdirs.pm:1372 > > + $versionString =~ /(\d+)\.(\d+)\.(\d+)/; > > what does versionString looks like on windows? 10.0.12345 Obviously that last part isn't accurate, but it is a large 4-5 digit number.
Jonathan Bedard
Comment 4 2020-02-19 07:38:50 PST
Created attachment 391160 [details] Patch for landing
WebKit Commit Bot
Comment 5 2020-02-19 08:37:04 PST
The commit-queue encountered the following flaky tests while processing attachment 391160 [details]: http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https.html bug 197297 (author: dbates@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-02-19 08:37:40 PST
Comment on attachment 391160 [details] Patch for landing Clearing flags on attachment: 391160 Committed r256920: <https://trac.webkit.org/changeset/256920>
WebKit Commit Bot
Comment 7 2020-02-19 08:37:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2020-02-19 08:39:07 PST
<rdar://problem/59591455>
Jonathan Bedard
Comment 9 2020-02-20 07:27:52 PST
Committed r257058: <https://trac.webkit.org/changeset/257058>
Note You need to log in before you can comment on or make changes to this bug.