Bug 207924

Summary: Reduce use of PlatformMediaSessionManager::sharedManager()
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

youenn fablet
Reported 2020-02-18 16:48:08 PST
Make PlatformMediaSession constructor protected
Attachments
Patch (2.37 KB, patch)
2020-02-18 16:48 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (13.85 KB, patch)
2020-02-18 17:18 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-02-18 16:48:49 PST
Created attachment 391120 [details] Patch
youenn fablet
Comment 2 2020-02-18 17:14:35 PST
Let's squash the current patch with "Reduce use of PlatformMediaSessionManager::sharedManager()"
youenn fablet
Comment 3 2020-02-18 17:18:22 PST
Created attachment 391121 [details] Patch
WebKit Commit Bot
Comment 4 2020-02-18 20:50:04 PST
The commit-queue encountered the following flaky tests while processing attachment 391121 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-02-18 20:50:35 PST
Comment on attachment 391121 [details] Patch Clearing flags on attachment: 391121 Committed r256904: <https://trac.webkit.org/changeset/256904>
WebKit Commit Bot
Comment 6 2020-02-18 20:50:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-02-18 20:51:16 PST
<rdar://problem/59578412>
Note You need to log in before you can comment on or make changes to this bug.