Bug 207950

Summary: Add support for AudioSession handling in GPUProcess for capture
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Archive of layout-test-results from webkit-cq-03 for mac-mojave none

youenn fablet
Reported 2020-02-19 11:01:03 PST
Add support for AudioSession handling in GPUProcess for capture
Attachments
Patch (45.57 KB, patch)
2020-02-19 11:03 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (55.24 KB, patch)
2020-02-19 14:52 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (55.28 KB, patch)
2020-02-19 15:10 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (55.28 KB, patch)
2020-02-19 17:17 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (55.28 KB, patch)
2020-02-19 17:24 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-03 for mac-mojave (3.49 MB, application/zip)
2020-02-19 18:44 PST, WebKit Commit Bot 		no flags
Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-02-19 11:03:09 PST
Created attachment 391179 [details] Patch
youenn fablet
Comment 2 2020-02-19 14:52:13 PST
Created attachment 391205 [details] Patch
youenn fablet
Comment 3 2020-02-19 15:10:23 PST
Created attachment 391207 [details] Patch
Eric Carlson
Comment 4 2020-02-19 15:31:28 PST
Comment on attachment 391207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391207&action=review > Source/WebCore/ChangeLog:10 > + Use this new interface fo MediaStreamTrack capture sources. s/fo/to/
Eric Carlson
Comment 5 2020-02-19 16:00:52 PST
Comment on attachment 391207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391207&action=review > Source/WebCore/ChangeLog:17 > + This includes BaseAudioSharedUnit, for which we add a audioUnitWillStart callback so that we compute the right AudioSession category before starting the capture. Nit: please wrap this line, it is quite long.
youenn fablet
Comment 6 2020-02-19 17:17:37 PST
Created attachment 391225 [details] Patch for landing
WebKit Commit Bot
Comment 7 2020-02-19 17:19:42 PST
Comment on attachment 391225 [details] Patch for landing Rejecting attachment 391225 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 391225, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/13325266
youenn fablet
Comment 8 2020-02-19 17:24:57 PST
Created attachment 391227 [details] Patch for landing
WebKit Commit Bot
Comment 9 2020-02-19 18:44:14 PST
Comment on attachment 391227 [details] Patch for landing Rejecting attachment 391227 [details] from commit-queue. New failing tests: editing/spelling/spellcheck-async-remove-frame.html Full output: https://webkit-queues.webkit.org/results/13325288
WebKit Commit Bot
Comment 10 2020-02-19 18:44:16 PST
Created attachment 391242 [details] Archive of layout-test-results from webkit-cq-03 for mac-mojave The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-mojave Platform: Mac OS X 10.14.6
WebKit Commit Bot
Comment 11 2020-02-19 19:50:42 PST
The commit-queue encountered the following flaky tests while processing attachment 391227 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 12 2020-02-19 19:51:27 PST
Comment on attachment 391227 [details] Patch for landing Clearing flags on attachment: 391227 Committed r257039: <https://trac.webkit.org/changeset/257039>
WebKit Commit Bot
Comment 13 2020-02-19 19:51:29 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 14 2020-02-19 19:52:15 PST
<rdar://problem/59616466>
Note You need to log in before you can comment on or make changes to this bug.