Bug 208486

Summary: [WebGL2] Implement texImage2D(TexImageSource) for RGBA/RGBA/UNSIGNED_BYTE ImageElements
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: WebGLAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, noam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126404    
Attachments:
Description Flags
Patch
none
Patch for landing none

Justin Fan
Reported 2020-03-02 16:50:35 PST
[WebGL2] Implement texImage2D(TexImageSource) for RGBA/RGBA/UNSIGNED_BYTE ImageElements
Attachments
Patch (4.60 MB, patch)
2020-03-02 17:04 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.60 MB, patch)
2020-03-03 12:35 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2020-03-02 17:04:42 PST
Created attachment 392219 [details] Patch
Justin Fan
Comment 2 2020-03-03 10:18:27 PST
Layout test crashes are unrelated to this patch.
Dean Jackson
Comment 3 2020-03-03 12:25:49 PST
Comment on attachment 392219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392219&action=review > Source/WebCore/ChangeLog:8 > + WIP implementation of WebGL 2 texImage2D(TexImageSource). Maybe say "Partial"? > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:3796 > + // Normal pure SW path. // Fallback software path.
Justin Fan
Comment 4 2020-03-03 12:35:54 PST
Created attachment 392311 [details] Patch for landing
WebKit Commit Bot
Comment 5 2020-03-03 13:26:05 PST
Comment on attachment 392311 [details] Patch for landing Clearing flags on attachment: 392311 Committed r257799: <https://trac.webkit.org/changeset/257799>
WebKit Commit Bot
Comment 6 2020-03-03 13:26:06 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-03-03 13:27:22 PST
<rdar://problem/60010521>
Note You need to log in before you can comment on or make changes to this bug.