Bug 208502

Summary: Web Inspector: the execution context picker is shown on pages with only one execution context if there are internal execution contexts
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
URL: https://devinrousso.com/demo/WebKit/stream_of_water.html
Bug Depends on: 206110    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2020-03-02 23:57:25 PST
# STEPS TO REPRODUCE: 1. inspect <https://devinrousso.com/demo/WebKit/stream_of_water.html> => the execution context picker is shown with: * Auto - stream_of_water.html ----- * stream_of_water.html This is because the page also has internal execution contexts, which are currently incorrectly counted when determining whether to show the execution context picker (we shouldn't show it if there is only one execution context). For non-engineering builds, internal execution contexts should be ignored.
Attachments
Patch (2.30 KB, patch)
2020-03-03 00:13 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-03-03 00:13:17 PST
Created attachment 392252 [details] Patch
WebKit Commit Bot
Comment 2 2020-03-04 12:46:47 PST
The commit-queue encountered the following flaky tests while processing attachment 392252 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2020-03-04 12:47:29 PST
Comment on attachment 392252 [details] Patch Clearing flags on attachment: 392252 Committed r257873: <https://trac.webkit.org/changeset/257873>
WebKit Commit Bot
Comment 4 2020-03-04 12:47:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2020-03-04 12:48:16 PST
<rdar://problem/60052184>
Note You need to log in before you can comment on or make changes to this bug.