Bug 208555

Summary:

Web Inspector: re-add `InspectorFrontendHost` support for moving the inspected window

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

All

OS:

All

Bug Depends on:

204627

Bug Blocks:

209346

Attachments:

Description	Flags
Patch	none
Patch	none

Devin Rousso

Reported 2020-03-03 20:18:40 PST

# STEPS TO REPRODUCE: 1. run WK1 2. inspect any page 3. detach/undock Web Inspector 4. try to drag the window around from the title area => nothing happens # STEPS TO REPRODUCE: 1. inspect any page 2. dock bottom 3. drag on the empty space around the tabs to resize the Web Inspector frame => nothing happens

Attachments
Patch (62.43 KB, patch) 2020-03-03 20:45 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (62.52 KB, patch) 2020-03-03 21:45 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2020-03-03 20:45:06 PST

Created attachment 392367 [details] Patch

WebKit Commit Bot

Comment 2 2020-03-03 21:41:07 PST Comment hidden (obsolete)

Comment on attachment 392367 [details] Patch Rejecting attachment 392367 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 392367, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: cpp M Source/WebKit/UIProcess/Inspector/mac/RemoteWebInspectorProxyMac.mm M Source/WebKit/UIProcess/Inspector/mac/WebInspectorProxyMac.mm M Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorProxyWin.cpp M Source/WebKit/UIProcess/Inspector/win/WebInspectorProxyWin.cpp M Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp M Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h M Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp M Source/WebKit/WebProcess/Inspector/WebInspectorUI.h M Source/WebKitLegacy/ios/ChangeLog M Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm M Source/WebKitLegacy/mac/ChangeLog M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm M Source/WebKitLegacy/win/ChangeLog M Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.cpp M Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.h ERROR from SVN: Merge conflict during commit: Conflict at '/trunk/Source/WebCore/ChangeLog' W: 884901ea07a9eccc835f7dcff35f7f8ed29ec086 and refs/remotes/origin/master differ, using rebase: :040000 040000 4240ff7048c0d69b7e32a7c4ea700cc72771f8c6 40439c00d217c2305f4452e279ba930d6d83bc22 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/inspector/InspectorFrontendClient.h M Source/WebCore/inspector/InspectorFrontendClientLocal.cpp M Source/WebCore/inspector/InspectorFrontendClientLocal.h M Source/WebCore/inspector/InspectorFrontendHost.cpp M Source/WebCore/inspector/InspectorFrontendHost.h M Source/WebCore/inspector/InspectorFrontendHost.idl M Source/WebCore/testing/Internals.cpp M Source/WebInspectorUI/ChangeLog M Source/WebInspectorUI/UserInterface/Base/Main.js M Source/WebInspectorUI/UserInterface/Views/TabBar.css M Source/WebInspectorUI/UserInterface/Views/TabBar.js M Source/WebInspectorUI/UserInterface/Views/TabBarItem.js M Source/WebKit/ChangeLog M Source/WebKit/UIProcess/Inspector/RemoteWebInspectorProxy.cpp M Source/WebKit/UIProcess/Inspector/RemoteWebInspectorProxy.h M Source/WebKit/UIProcess/Inspector/RemoteWebInspectorProxy.messages.in M Source/WebKit/UIProcess/Inspector/WebInspectorProxy.cpp M Source/WebKit/UIProcess/Inspector/WebInspectorProxy.h M Source/WebKit/UIProcess/Inspector/WebInspectorProxy.messages.in M Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp M Source/WebKit/UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp M Source/WebKit/UIProcess/Inspector/mac/RemoteWebInspectorProxyMac.mm M Source/WebKit/UIProcess/Inspector/mac/WebInspectorProxyMac.mm M Source/WebKit/UIProcess/Inspector/win/RemoteWebInspectorProxyWin.cpp M Source/WebKit/UIProcess/Inspector/win/WebInspectorProxyWin.cpp M Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.cpp M Source/WebKit/WebProcess/Inspector/RemoteWebInspectorUI.h M Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp M Source/WebKit/WebProcess/Inspector/WebInspectorUI.h M Source/WebKitLegacy/ios/ChangeLog M Source/WebKitLegacy/ios/WebCoreSupport/WebInspectorClientIOS.mm M Source/WebKitLegacy/mac/ChangeLog M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.h M Source/WebKitLegacy/mac/WebCoreSupport/WebInspectorClient.mm M Source/WebKitLegacy/win/ChangeLog M Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.cpp M Source/WebKitLegacy/win/WebCoreSupport/WebInspectorClient.h ERROR from SVN: Merge conflict during commit: Conflict at '/trunk/Source/WebCore/ChangeLog' W: 884901ea07a9eccc835f7dcff35f7f8ed29ec086 and refs/remotes/origin/master differ, using rebase: :040000 040000 4240ff7048c0d69b7e32a7c4ea700cc72771f8c6 40439c00d217c2305f4452e279ba930d6d83bc22 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 592a6e99cd7..e44b9135a5e master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 257822 = 592a6e99cd7068f4c0a0fd8b3f914254d688d2f1 r257828 = c7c729ede583a675809551f111150fd23e39e0f3 r257830 = e44b9135a5e97840659f27e71e415641cf50ba17 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13333222

Devin Rousso

Comment 3 2020-03-03 21:45:05 PST

Created attachment 392372 [details] Patch

WebKit Commit Bot

Comment 4 2020-03-03 22:31:15 PST

Comment on attachment 392372 [details] Patch Clearing flags on attachment: 392372 Committed r257835: <https://trac.webkit.org/changeset/257835>

WebKit Commit Bot

Comment 5 2020-03-03 22:31:17 PST

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2020-03-03 22:33:09 PST

<rdar://problem/60027760>

Note You need to log in before you can comment on or make changes to this bug.