Bug 214897

Summary: Roll ANGLE to 2020-07-28
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, dino, don.olmstead, ews-watchlist, graouts, gyuyoung.kim, jdarpinian, kondapallykalyan, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 212228, 212717    
Bug Blocks: 126404, 214945    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Kenneth Russell
Reported 2020-07-28 14:39:54 PDT
In order to pass more WebGL 2.0 conformance tests, in particular some sRGB-related ones, WebKit's snapshot of ANGLE must be rolled forward to pick up recent upstream fixes.
Attachments
Patch (9.96 MB, patch)
2020-07-28 18:37 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (9.96 MB, patch)
2020-07-29 11:54 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (9.96 MB, patch)
2020-07-29 12:49 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (9.96 MB, patch)
2020-07-29 13:52 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-07-28 18:37:37 PDT
Created attachment 405432 [details] Patch
EWS Watchlist
Comment 2 2020-07-28 18:39:55 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 3 2020-07-28 18:51:56 PDT
It looks like WinCairo doesn't build with USE(ZLIB) enabled. Any ideas how to stub out the compression-related functions in Source/ThirdParty/ANGLE/third_party/zlib/google/ ? To date we haven't put WebKit-style USE(...) macros in that code.
Don Olmstead
Comment 4 2020-07-29 11:52:29 PDT
(In reply to Kenneth Russell from comment #3) > It looks like WinCairo doesn't build with USE(ZLIB) enabled. > > Any ideas how to stub out the compression-related functions in > Source/ThirdParty/ANGLE/third_party/zlib/google/ ? To date we haven't put > WebKit-style USE(...) macros in that code. From the build output it can't find a z_const definition. We don't use stock zlib we actually use zlib-ng. There's a PR for adding back z_const, https://github.com/zlib-ng/zlib-ng/pull/704, that should fix it. I would need to apply that to our requirements repository for the build to get further.
Kenneth Russell
Comment 5 2020-07-29 11:54:30 PDT
Created attachment 405479 [details] Patch
Kenneth Russell
Comment 6 2020-07-29 12:49:57 PDT
Created attachment 405488 [details] Patch
Kenneth Russell
Comment 7 2020-07-29 12:51:52 PDT
Thanks Don for your suggestion. Was able to put in a local workaround for the missing z_const preprocessor definition in the newly-introduced zlib wrapper in this patch. Now working through link errors in the WinCairo build.
Kenneth Russell
Comment 8 2020-07-29 13:52:35 PDT
Created attachment 405495 [details] Patch
Kenneth Russell
Comment 9 2020-07-29 14:29:47 PDT
Thanks achristensen@ for your review! Relieved that this is passing the WinCairo bot now. Will wait for more EWS bots to complete before marking this CQ+.
Kenneth Russell
Comment 10 2020-07-29 15:35:30 PDT
Everything's green. mac-debug-wk1 is backed up and hasn't started yet but it was green on earlier patches. CQ'ing now.
EWS
Comment 11 2020-07-29 15:47:56 PDT
Committed r265064: <https://trac.webkit.org/changeset/265064> All reviewed patches have been landed. Closing bug and clearing flags on attachment 405495 [details].
Radar WebKit Bug Importer
Comment 12 2020-07-29 15:48:38 PDT
<rdar://problem/66296668>
Note You need to log in before you can comment on or make changes to this bug.