Bug 215840

Summary: [JSC] Implement Intl.DateTimeFormat fractionalSecondDigits
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 213425    
Attachments:
Description Flags
Patch
ross.kirsling: review+
Patch none

Yusuke Suzuki
Reported 2020-08-25 23:21:02 PDT
https://github.com/tc39/ecma402/pull/347
Attachments
Patch (15.81 KB, patch)
2020-08-26 00:34 PDT, Yusuke Suzuki 		ross.kirsling: review+
DetailsFormatted DiffDiff
Patch (15.87 KB, patch)
2020-08-26 00:53 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-08-25 23:23:11 PDT
This looks like about to be landed. We should support it.
Yusuke Suzuki
Comment 2 2020-08-26 00:34:56 PDT
Created attachment 407277 [details] Patch
Ross Kirsling
Comment 3 2020-08-26 00:40:57 PDT
Comment on attachment 407277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407277&action=review Easy-peasy! :) > Source/JavaScriptCore/builtins/DatePrototype.js:52 > + options.fractionalSecondDigits == @undefined ===, right? > Source/JavaScriptCore/builtins/DatePrototype.js:168 > + options.fractionalSecondDigits == @undefined Ditto. > JSTests/stress/intl-datetimeformat.js:704 > + "fractionalSecondDigits", nit: Indentation is off here (and also further above), though it doesn't matter much in a test file.
Yusuke Suzuki
Comment 4 2020-08-26 00:52:29 PDT
Comment on attachment 407277 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407277&action=review Thanks! >> Source/JavaScriptCore/builtins/DatePrototype.js:52 >> + options.fractionalSecondDigits == @undefined > > ===, right? Oops! Thanks. >> Source/JavaScriptCore/builtins/DatePrototype.js:168 >> + options.fractionalSecondDigits == @undefined > > Ditto. Fixed. >> JSTests/stress/intl-datetimeformat.js:704 >> + "fractionalSecondDigits", > > nit: Indentation is off here (and also further above), though it doesn't matter much in a test file. Fixed.
Yusuke Suzuki
Comment 5 2020-08-26 00:53:44 PDT
Created attachment 407281 [details] Patch Patch for landing
EWS
Comment 6 2020-08-26 09:48:38 PDT
Committed r266170: <https://trac.webkit.org/changeset/266170> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407281 [details].
Radar WebKit Bug Importer
Comment 7 2020-08-26 09:49:13 PDT
<rdar://problem/67811354>
Note You need to log in before you can comment on or make changes to this bug.