Bug 219656

Summary: TextManipulationController sometimes fails to notify its delegate of new text (if an element has been removed)
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mifenton, sihui_liu, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 202874    
Attachments:
Description Flags
Patch
wenson_hsieh: review+
Patch for landing
ews-feeder: commit-queue-
Patch for landing none

Geoffrey Garen
Reported 2020-12-08 14:26:05 PST
TextManipulationController sometimes fails to notify its delegate of new text (if an element has been removed)
Attachments
Patch (7.25 KB, patch)
2020-12-08 14:38 PST, Geoffrey Garen 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch for landing (7.25 KB, patch)
2020-12-08 15:15 PST, Geoffrey Garen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (7.25 KB, patch)
2020-12-08 15:19 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2020-12-08 14:38:04 PST
Created attachment 415678 [details] Patch
Wenson Hsieh
Comment 2 2020-12-08 14:41:05 PST
Comment on attachment 415678 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=415678&action=review r=mews > Source/WebCore/editing/TextManipulationController.cpp:646 > + if (!m_pendingItemsForCallback.size()) Nit - I think .isEmpty() might read a bit better here.
Geoffrey Garen
Comment 3 2020-12-08 15:15:14 PST
Created attachment 415681 [details] Patch for landing
EWS
Comment 4 2020-12-08 15:16:18 PST
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Geoffrey Garen
Comment 5 2020-12-08 15:19:46 PST
Created attachment 415682 [details] Patch for landing
EWS
Comment 6 2020-12-08 16:04:00 PST
Committed r270561: <https://trac.webkit.org/changeset/270561> All reviewed patches have been landed. Closing bug and clearing flags on attachment 415682 [details].
Radar WebKit Bug Importer
Comment 7 2020-12-08 16:07:00 PST
<rdar://problem/72113973>
Note You need to log in before you can comment on or make changes to this bug.