Bug 220744

Summary: [webkitcorepy] Support alternative default pypi url on macOS
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, jlewis3, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 220736    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Jonathan Bedard
Reported 2021-01-19 13:00:29 PST
A bit of a niche use-case for some of Apple's automated infrastructure.
Attachments
Patch (3.07 KB, patch)
2021-01-19 13:52 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.14 KB, patch)
2021-01-19 15:50 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.37 KB, patch)
2021-01-20 08:01 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-01-19 13:02:12 PST
<rdar://problem/73369338>
Jonathan Bedard
Comment 2 2021-01-19 13:52:26 PST
Created attachment 417908 [details] Patch
Aakash Jain
Comment 3 2021-01-19 15:28:19 PST
Comment on attachment 417908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417908&action=review > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:320 > + parts = line.split('/') is it reliable way to depend on the line containing certain number of slashes. Can we explicitly read index/index-url from the file?
Aakash Jain
Comment 4 2021-01-19 15:29:18 PST
maybe using a regex starting with https://
Jonathan Bedard
Comment 5 2021-01-19 15:36:16 PST
(In reply to Aakash Jain from comment #4) > maybe using a regex starting with https:// Will replace this with a regex.
Jonathan Bedard
Comment 6 2021-01-19 15:50:24 PST
Created attachment 417919 [details] Patch for landing
EWS
Comment 7 2021-01-19 16:34:49 PST
Committed r271630: <https://trac.webkit.org/changeset/271630> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417919 [details].
Jonathan Bedard
Comment 8 2021-01-20 08:01:50 PST
Reopening to attach new patch.
Jonathan Bedard
Comment 9 2021-01-20 08:01:51 PST
Created attachment 417969 [details] Patch for landing
Jonathan Bedard
Comment 10 2021-01-20 08:03:01 PST
Committed r271649: <https://trac.webkit.org/changeset/271649>
Note You need to log in before you can comment on or make changes to this bug.