Bug 230445

Summary: Remove use of NSScrollAnimationHelper for animated scrolls
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mrobinson: review+
Patch none

Simon Fraser (smfr)
Reported 2021-09-18 12:13:50 PDT
Remove use of NSScrollAnimationHelper for animated scrolls
Attachments
Patch (15.09 KB, patch)
2021-09-18 12:15 PDT, Simon Fraser (smfr) 		mrobinson: review+
DetailsFormatted DiffDiff
Patch (14.88 KB, patch)
2021-09-18 12:41 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-09-18 12:15:37 PDT
Created attachment 438565 [details] Patch
Martin Robinson
Comment 2 2021-09-18 12:23:26 PDT
Comment on attachment 438565 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=438565&action=review This is a great cleanup! > Source/WebCore/platform/ScrollAnimator.cpp:109 > + WTFLogAlways("scrollToPositionWithoutAnimation to %.2f", adjustedPosition.y()); Are these WTFLogAlways calls left over or did you mean to add them? > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:54 > static bool scrollAnimationEnabledForSystem() I think this can be removed and moved into the body of platformAllowsScrollAnimation. I don't think it's used anywhere else.
Simon Fraser (smfr)
Comment 3 2021-09-18 12:29:13 PDT
(In reply to Martin Robinson from comment #2) > Comment on attachment 438565 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=438565&action=review > > This is a great cleanup! > > > Source/WebCore/platform/ScrollAnimator.cpp:109 > > + WTFLogAlways("scrollToPositionWithoutAnimation to %.2f", adjustedPosition.y()); I didn't mean to leave this in. > > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:54 > > static bool scrollAnimationEnabledForSystem() > > I think this can be removed and moved into the body of > platformAllowsScrollAnimation. I don't think it's used anywhere else. Sure.
Simon Fraser (smfr)
Comment 4 2021-09-18 12:41:52 PDT
Created attachment 438566 [details] Patch
EWS
Comment 5 2021-09-18 15:45:00 PDT
Committed r282730 (241867@main): <https://commits.webkit.org/241867@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 438566 [details].
Radar WebKit Bug Importer
Comment 6 2021-09-18 15:45:16 PDT
<rdar://problem/83274425>
Note You need to log in before you can comment on or make changes to this bug.