Bug 230681

Summary: Use visibleToHitTesting() in RenderLayerBacking::updateAfterDescendants() instead of pointer-events check
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: Layout and RenderingAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84635, 229330    
Attachments:
Description Flags
Patch none

Tim Nguyen (:ntim)
Reported 2021-09-23 02:12:29 PDT
visibleToHitTesting() will account for inert as well.
Attachments
Patch (1.73 KB, patch)
2021-09-23 02:17 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2021-09-23 02:17:30 PDT
Created attachment 439028 [details] Patch
Antti Koivisto
Comment 2 2021-09-23 03:31:25 PDT
Comment on attachment 439028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439028&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:1593 > - bool userInteractive = renderer().style().pointerEvents() != PointerEvents::None; > + bool userInteractive = renderer().visibleToHitTesting(); This also adds visibility test but I guess that is fine.
EWS
Comment 3 2021-09-23 04:55:34 PDT
Committed r282957 (242047@main): <https://commits.webkit.org/242047@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439028 [details].
Radar WebKit Bug Importer
Comment 4 2021-09-23 04:56:42 PDT
<rdar://problem/83442427>
Note You need to log in before you can comment on or make changes to this bug.