Bug 230686

Summary: Replace Node::isInert() with RenderStyle::effectiveInert()
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: DOMAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cdumez, cfleizach, changseok, cmarcelo, dmazzoni, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jcraig, jdiggs, kangil.han, koivisto, kondapallykalyan, pdr, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 229330    
Bug Blocks: 84635    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch none

Tim Nguyen (:ntim)
Reported 2021-09-23 05:11:10 PDT
The latter is less buggy, and one source of truth is always better.
Attachments
Patch (13.35 KB, patch)
2021-09-23 08:05 PDT, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.24 KB, patch)
2021-09-23 09:49 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (13.25 KB, patch)
2021-09-25 06:56 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (9.31 KB, patch)
2021-09-27 02:27 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2021-09-23 08:05:36 PDT
Created attachment 439043 [details] Patch
Tim Nguyen (:ntim)
Comment 2 2021-09-23 09:49:42 PDT
Created attachment 439053 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2021-09-25 06:56:44 PDT
Created attachment 439263 [details] Patch
Antti Koivisto
Comment 4 2021-09-27 01:25:57 PDT
Comment on attachment 439263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=439263&action=review > Source/WebCore/dom/Element.cpp:3537 > + // FIXME: Replace inert/modal dialog logic with style->effectiveInert() after fixing invalidation > + auto elementHasInertAttribute = [](Element& element) -> bool { > + return element.document().settings().inertAttributeEnabled() && is<HTMLElement>(element) && element.hasAttribute(HTMLNames::inertAttr); > + }; > + > + if (elementHasInertAttribute(const_cast<Element&>(*this))) > + return false; > + > + Node* activeModalDialog = document().activeModalDialog(); > + if (activeModalDialog && !activeModalDialog->containsIncludingShadowDOM(this)) > + return false; This doesn't look correct. I can look at some point into resolving this correctly via style. Meanwhile I think you should leave Node::isInert() equivalent in place (that is compute inertness separately from DOM) and use that in isFocusable() as before. Or you could just let whatever focusability-with-inert-test you are trying to fix regress. It is probably not critical at this point.
Tim Nguyen (:ntim)
Comment 5 2021-09-27 02:27:21 PDT
Created attachment 439336 [details] Patch
EWS
Comment 6 2021-09-27 04:25:57 PDT
Committed r283105 (242163@main): <https://commits.webkit.org/242163@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 439336 [details].
Radar WebKit Bug Importer
Comment 7 2021-09-27 04:26:19 PDT
<rdar://problem/83568603>
Note You need to log in before you can comment on or make changes to this bug.