Bug 232711

Summary: AX: rename actionVerb() as localizedActionVerb()
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 230253    
Attachments:
Description Flags
Patch andresg_22: review+

Carlos Garcia Campos
Reported 2021-11-04 06:48:28 PDT
Since it's returning the localized name. In ATSPI there are two methods in the action interface GetName and GetLocalizedName so we need both.
Attachments
Patch (13.03 KB, patch)
2021-11-04 06:51 PDT, Carlos Garcia Campos 		andresg_22: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-04 06:48:42 PDT
<rdar://problem/85015496>
Carlos Garcia Campos
Comment 2 2021-11-04 06:51:08 PDT
Created attachment 443301 [details] Patch
Andres Gonzalez
Comment 3 2021-11-04 07:16:00 PDT
(In reply to Carlos Garcia Campos from comment #2) > Created attachment 443301 [details] > Patch --- a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp +++ a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp -String AccessibilityRenderObject::actionVerb() const ... So this was duplicated in the subclass? Thanks for cleaning that up!
Carlos Garcia Campos
Comment 4 2021-11-04 07:21:47 PDT
(In reply to Andres Gonzalez from comment #3) > (In reply to Carlos Garcia Campos from comment #2) > > Created attachment 443301 [details] > > Patch > > --- a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp > +++ a/Source/WebCore/accessibility/AccessibilityRenderObject.cpp > > -String AccessibilityRenderObject::actionVerb() const > ... > > So this was duplicated in the subclass? Thanks for cleaning that up! Yes, almost duplicated, the base class handles menu actions too.
Carlos Garcia Campos
Comment 5 2021-11-05 01:23:49 PDT
Committed r285340 (243901@main): <https://commits.webkit.org/243901@main>
Note You need to log in before you can comment on or make changes to this bug.