Bug 240701
| Summary: | "No new tests (OOPS!)." is ending up in the middle of commit messages | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | cdumez, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=240585 https://bugs.webkit.org/show_bug.cgi?id=239665 |
||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Simon Fraser (smfr)
The pre-filled commit message for https://github.com/WebKit/WebKit/pull/814 ended up like:
5dd145e
ASSERT(status == U_ZERO_ERROR) under SearchBuffer::search() when typing in the url bar in the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=240699
<rdar://92182174>
Reviewed by NOBODY (OOPS!).
Replace `status == U_ZERO_ERROR` tests with `U_SUCCESS(status)`.
* Source/WebCore/PAL/pal/text/TextCodecICU.cpp:
(PAL::ErrorCallbackSetter::ErrorCallbackSetter):
(PAL::ErrorCallbackSetter::~ErrorCallbackSetter):
* Source/WebKit/UIProcess/Cocoa/ModalContainerControlClassifier.mm:
(WebKit::SpoofChecker::checker):
No new tests (OOPS!).
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::createSearcher):
(WebCore::SearchBuffer::SearchBuffer):
(WebCore::SearchBuffer::~SearchBuffer):
(WebCore::SearchBuffer::search):
Note "No new tests (OOPS!)." in the middle which I totally missed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/94013879>
Ryan Haddad
*** Bug 239665 has been marked as a duplicate of this bug. ***
Ryan Haddad
Duped the wrong way, sorry!
*** This bug has been marked as a duplicate of bug 239665 ***