Bug 242536
| Summary: | [git-webkit] Allow for re-running pre-pr checks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | annevk, ap, jbedard, ryanhaddad, simon.fraser, webkit-bug-importer, y_soliman |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Simon Fraser (smfr)
`webkit-patch upload` would let me fix style issues locally, when the style checker found them, while the command is running and without having to cancel and re-run the command.
`git webkit pr` doesn't seem to have this same feature, making it more cumbersome to fix style errors.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/97093963>
Simon Fraser (smfr)
This is one my top `git webkit` annoyances, and shouldn't be hard to fix.
Anne van Kesteren
I think an intermediate fix where you have to re-run the command but it at least hasn't side-effected would already be a major improvement.
A big part of the problem here is that it creates a branch and then finds a style error and at that point you can no longer run the same command as you're on a branch.
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/15694
EWS
Committed 270007@main (052c4c37d40f): <https://commits.webkit.org/270007@main>
Reviewed commits have been landed. Closing PR #15694 and removing active labels.
EWS
Committed 267815.489@safari-7617-branch (b7a0e360e4b6): <https://commits.webkit.org/267815.489@safari-7617-branch>
Reviewed commits have been landed. Closing PR #904 and removing active labels.