Bug 244283
| Summary: | Re-using a bugzilla bug for a PR tried to re-use an old PR | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | ap, jbedard, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 239082 | ||
Simon Fraser (smfr)
I had an existing branch for a PR for https://bugs.webkit.org/show_bug.cgi?id=244134, but had not pushed a PR yet (because of the issue in https://github.com/WebKit/WebKit/pull/3580).
When on that branch, I did `git webkit pr --no-update`, and it tried to push the PR to https://github.com/WebKit/WebKit/pull/3482. I expected it to make a new PR.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Fraser (smfr)
Then I got stuck on my local PR branch, unable to specify a new bug to push to. I then deleted this branch with `git branch -D` but I still get:
OpenSource % git webkit pr --issue 244285
'eng/REGRESSION253549main--iOS--2X-animationsLayout-tests-are-constant-failures' already exists
Abandoning pushing pull-request because 'eng/REGRESSION253549main--iOS--2X-animationsLayout-tests-are-constant-failures' could not be created
Radar WebKit Bug Importer
<rdar://problem/99065079>
Jonathan Bedard
This is either fixed by https://bugs.webkit.org/show_bug.cgi?id=244660 or not-to-be-fixed.
Ultimately, GitHub uses branch names as the primary identifier for PRs. We can use state and author to further differentiate, but beyond that, branch names are the primary PR identifier.