Bug 246380

Summary:	webkit pr should have an option not to create a commit
Product:	WebKit	Reporter:	Matt Woodrow <mattwoodrow>
Component:	Tools / Tests	Assignee:	Matt Woodrow <mattwoodrow>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Matt Woodrow

Reported 2022-10-11 19:08:22 PDT

I generally don't want `git webkit pr` to create new commits for me, since I prefer to manage my git state manually. --no-add stops it from adding new files to the index, but it'll still create a new commit (or amend/squash) if there's anything staged.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-10-11 19:09:54 PDT

<rdar://problem/101060897>

Matt Woodrow

Comment 2 2022-10-11 19:11:19 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5272

EWS

Comment 3 2022-10-13 11:40:24 PDT

Committed 255495@main (72ad3b19fdd6): <https://commits.webkit.org/255495@main> Reviewed commits have been landed. Closing PR #5272 and removing active labels.

EWS

Comment 4 2022-10-18 11:19:57 PDT

Committed 252432.589@safari-7614-branch (8f84dd973596): <https://commits.webkit.org/252432.589@safari-7614-branch> Reviewed commits have been landed. Closing PR #140 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.