Bug 255785

Summary:	Do not deref CreationData's buffer when Cairo font is destroyed.
Product:	WebKit	Reporter:	Vitaly Dyackhov <vitaly>
Component:	WPE WebKit	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, clopez
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=255476

Vitaly Dyackhov

Reported 2023-04-21 06:49:24 PDT

Since 263084@main `FontCustomPlatformData` takes `FontPlatformData::CreationData` instead of `FragmentedSharedBuffer`. The buffer is now a reference counted field of `FontPlatformData::CreationData` struct and will be automatically dereferenced when `FontCustomPlatformData` is destroyed. It is an error to manually dereference it using Cairo font destroy function.

Attachments
Add attachment proposed patch, testcase, etc.

Vitaly Dyackhov

Comment 1 2023-04-21 06:55:48 PDT

Pull request: https://github.com/WebKit/WebKit/pull/13029

EWS

Comment 2 2023-04-21 12:44:52 PDT

Committed 263258@main (dc4c470f9471): <https://commits.webkit.org/263258@main> Reviewed commits have been landed. Closing PR #13029 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.