Bug 265673
| Summary: | [scroll-animations] WPT test scroll-animations/css/view-timeline-shorthand.html has incorrect contraction tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> |
| Component: | Animations | Assignee: | Antoine Quint <graouts> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, graouts, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://github.com/web-platform-tests/wpt/pull/43478 | ||
| Bug Depends on: | |||
| Bug Blocks: | 265668 | ||
Antoine Quint
There are three tests at the end of the WPT test scroll-animations/css/view-timeline-shorthand.html:
```
test_shorthand_contraction('view-timeline', {
'view-timeline-name': '--a, --b, --c',
'view-timeline-axis': 'inline, inline',
'view-timeline-inset': 'auto, auto',
}, '');
test_shorthand_contraction('view-timeline', {
'view-timeline-name': '--a, --b',
'view-timeline-axis': 'inline, inline, inline',
'view-timeline-inset': 'auto, auto, auto',
}, '');
test_shorthand_contraction('view-timeline', {
'view-timeline-name': '--a, --b',
'view-timeline-axis': 'inline, inline',
'view-timeline-inset': 'auto, auto, auto',
}, '');
```
These are wrong in the same way that the equivalent `scroll-timeline` shorthand tests were and which got fixed in 271190@main after discussion at https://github.com/web-platform-tests/wpt/issues/43336. Indeed, the computed value should trim the longhands to match the length of `view-timeline-name`.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Antoine Quint
Pull request: https://github.com/WebKit/WebKit/pull/21166
Antoine Quint
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/43478
EWS
Committed 271397@main (3ec49d8dfd30): <https://commits.webkit.org/271397@main>
Reviewed commits have been landed. Closing PR #21166 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/119041818>