Bug 270220

Summary: Factor out WEBKIT_{APPEND,PREPEND}_GLOBAL_{C,CXX}_COMPILER_FLAGS
Product: WebKit Reporter: Adrian Perez <aperez>
Component: CMakeAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 270162    
Bug Blocks:    

Adrian Perez
Reported 2024-02-28 04:39:40 PST
Each of the following macros has almost the same code, and could use a common implementation: - WEBKIT_PREPEND_GLOBAL_C_FLAGS() - WEBKIT_APPEND_GLOBAL_C_FLAGS() - WEBKIT_PREPEND_GLOBAL_CXX_FLAGS() - WEBKIT_APPEND_GLOBAL_CXX_FLAGS() Moreover, after bug #270162 they could reuse WEBKIT_CHECK_COMPILER_FLAGS() which would also fix caching results for checked flags that contain equals (=) characters. Currently a few are still re-checked on every CMake run unneccessarily.
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2024-02-28 05:07:05 PST
Pull request: https://github.com/WebKit/WebKit/pull/25224
EWS
Comment 2 2024-02-28 07:56:07 PST
Committed 275444@main (0687b6d53df5): <https://commits.webkit.org/275444@main> Reviewed commits have been landed. Closing PR #25224 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.