Bug 32915

Summary: valueAsDate setter Part 2: ISODateTime -> String conversion
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#dom-input-valueasdate
Bug Depends on: 32901    
Bug Blocks: 32697    
Attachments:
Description Flags
Proposed patch mjs: review-, tkent: commit-queue-

Kent Tamura
Reported 2009-12-23 21:31:37 PST
In order to implement HTMLInputElement::setValueAsDate, we need to implement 1. millisecond double value to ISODateTime conversion 2. ISODateTime to String conversion This bug handles the step 2 above.
Attachments
Proposed patch (6.39 KB, patch)
2009-12-23 21:40 PST, Kent Tamura 		mjs: review-
tkent: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2009-12-23 21:40:16 PST
Created attachment 45462 [details] Proposed patch This patch depends on the patch in Bug#32901.
WebKit Review Bot
Comment 2 2009-12-23 21:44:04 PST
Attachment 45462 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/143618
WebKit Review Bot
Comment 3 2009-12-23 21:45:13 PST
style-queue ran check-webkit-style on attachment 45462 [details] without any errors.
Kent Tamura
Comment 4 2009-12-23 21:48:05 PST
(In reply to comment #2) > Attachment 45462 [details] did not build on chromium: > Build output: http://webkit-commit-queue.appspot.com/results/143618 It's expected. This patch depends on a uncommitted patch.
WebKit Review Bot
Comment 5 2009-12-26 06:15:34 PST
Attachment 45462 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/145780
Maciej Stachowiak
Comment 6 2009-12-28 02:12:59 PST
Comment on attachment 45462 [details] Proposed patch This patch lacks tests. Perhaps it is only testable in combination with part 1, in which case I'd rather see the two combined into one patch with tests included.
Kent Tamura
Comment 7 2009-12-29 08:54:04 PST
Deprecated by Bug#33021.
Note You need to log in before you can comment on or make changes to this bug.