Bug 33227
| Summary: | check-webkit-style should warn about tabs in any file | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, cjerdonek, hamaji, levin, tkent |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
| Bug Depends on: | 33734 | ||
| Bug Blocks: | |||
Eric Seidel (no email)
check-webkit-style should warn about tabs in any file
At least I think this should be check-webkit-style's job.
https://bugs.webkit.org/show_bug.cgi?id=33221#c3
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
I don't see any reason to forbid tabs in regression tests (not to mention make files).
Adam Barth
We should use the same rules as the pre-commit hook.
David Levin
(In reply to comment #1)
> I don't see any reason to forbid tabs in regression tests (not to mention make
> files).
Agreed. fwiw, I purposely got regression tests (directories) omitted when I reviewed the change that checks for TABs.
Kent Tamura
I think we may have a whitelist for tab checking.
For example, we may forbid tabs in LayoutTests/.../script-tests/*.js
Eric Seidel (no email)
the pre-commit hook warns unless you set the svn property "allow-tabs". check-webkit-style should do the same. svn patches from svn-create-patch include properties on new files. For existing files we can teach scm.py how to expose the current properties on a file.