Bug 33356

Summary: style-queue should not complain about identifier names with underscores under WebKit/gtk/webkit/
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cjerdonek, commit-queue, gustavo, hamaji, levin, mjs
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Gustavo Noronha (kov)
Reported 2010-01-07 17:06:52 PST
Our APIs use GTK+ style naming, so we need to use lower-cased, _-separated names there. An example of this happenning: https://bugs.webkit.org/show_bug.cgi?id=32819#c4
Attachments
Patch (2.59 KB, patch)
2010-01-17 15:56 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (2.55 KB, patch)
2010-01-17 16:44 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-01-17 15:56:29 PST
Created attachment 46765 [details] Patch
Adam Barth
Comment 2 2010-01-17 16:44:23 PST
Created attachment 46771 [details] Patch
David Levin
Comment 3 2010-01-19 11:06:09 PST
Looks fine to me, but I'd prefer Hamaji to review (and Chris to comment if he wishes), since they have been a huge amount on this (and there may be a better way that they put in place).
Chris Jerdonek
Comment 4 2010-01-19 19:14:19 PST
I would prefer to keep filename-specific logic out of cpp_style.py, and to do something like this as a configuration in checker.py. I made a bug report about this last week here: https://bugs.webkit.org/show_bug.cgi?id=33684 But because that enhancement isn't implemented yet, I think it's fine for now. I'll go ahead and make a note in that report that this is another use-case for directory-specific exemptions from particular rules. When that's implemented, this change can be refactored.
WebKit Commit Bot
Comment 5 2010-01-21 11:54:24 PST
Comment on attachment 46771 [details] Patch Clearing flags on attachment: 46771 Committed r53636: <http://trac.webkit.org/changeset/53636>
WebKit Commit Bot
Comment 6 2010-01-21 11:54:30 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.