Bug 39590

Summary: Provide DeviceOrientation LayoutTests
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hans, jorlow, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 39588, 39589, 43181    
Bug Blocks: 30335    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Steve Block
Reported 2010-05-24 03:22:14 PDT
Provide DeviceOrientation LayoutTests
Attachments
Patch (17.02 KB, patch)
2010-09-07 01:53 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (21.11 KB, patch)
2010-09-07 03:22 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (21.20 KB, patch)
2010-09-07 04:31 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2010-09-07 01:53:14 PDT
Created attachment 66694 [details] Patch
Steve Block
Comment 2 2010-09-07 01:54:31 PDT
Hans, did you have any other test cases in mind?
Hans Wennborg
Comment 3 2010-09-07 02:25:01 PDT
(In reply to comment #2) > Hans, did you have any other test cases in mind? This looks very good. Perhaps we should test pushing an orientation through where one or more of the angles is NULL to make sure an implementation doesn't forget to handle that?
Steve Block
Comment 4 2010-09-07 03:22:31 PDT
Created attachment 66700 [details] Patch
Steve Block
Comment 5 2010-09-07 04:31:42 PDT
Created attachment 66705 [details] Patch
Jeremy Orlow
Comment 6 2010-09-07 04:32:56 PDT
r=me
Steve Block
Comment 7 2010-09-07 04:34:35 PDT
Updated patch which makes sure we only ever pass boolean or numeric values to layoutTestController.setMockDeviceOrientation(). Hans, if this looks good to you, I'll cq+.
Hans Wennborg
Comment 8 2010-09-07 04:53:02 PDT
Looks good. Thanks.
WebKit Commit Bot
Comment 9 2010-09-07 05:12:09 PDT
Comment on attachment 66705 [details] Patch Clearing flags on attachment: 66705 Committed r66876: <http://trac.webkit.org/changeset/66876>
WebKit Commit Bot
Comment 10 2010-09-07 05:12:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.