Bug 45694

Summary: 'seeking' event should always fire
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 51249    
Attachments:
Description Flags
Proposed patch.
simon.fraser: review+
Revised patch simon.fraser: review+

Eric Carlson
Reported 2010-09-13 11:51:24 PDT
In r5219 the spec was changed to require the 'seeking' event to always fire.
Attachments
Proposed patch. (6.67 KB, patch)
2010-09-13 12:15 PDT, Eric Carlson 		simon.fraser: review+
DetailsFormatted DiffDiff
Revised patch (6.88 KB, patch)
2010-09-23 09:00 PDT, Eric Carlson 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2010-09-13 12:15:55 PDT
Created attachment 67449 [details] Proposed patch.
Eric Carlson
Comment 2 2010-09-23 09:00:25 PDT
Created attachment 68527 [details] Revised patch
Simon Fraser (smfr)
Comment 3 2010-09-23 11:39:34 PDT
Comment on attachment 67449 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=67449&action=review > WebCore/ChangeLog:6 > + 'seeking' event should always fire > + https://bugs.webkit.org/show_bug.cgi?id=45694 Is this just a change to the spec that we're following? If so, the changelog should say. > WebCore/html/HTMLMediaElement.cpp:1099 > + // 2 - If the element's seeking IDL attribute is true, then another instance of this algorithm is > + // already running. Abort that other instance of the algorithm without waiting for the step that > + // it is running to complete. I don't understand how "another instance of the algorithm" can be running on the same element. Can the comment clarify this?
Eric Carlson
Comment 4 2010-09-23 12:38:20 PDT
http://trac.webkit.org/changeset/68181
Ademar Reis
Comment 5 2011-01-24 12:17:44 PST
Revision r68181 cherry-picked into qtwebkit-2.2 with commit d7a0127 <http://gitorious.org/webkit/qtwebkit/commit/d7a0127>
Note You need to log in before you can comment on or make changes to this bug.