Bug 46665

Summary: Patch RenderView's layout and computeLogicalWidth/Height methods to be block-flow-aware.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
sam: review-
Patch sam: review+

Dave Hyatt
Reported 2010-09-27 15:26:37 PDT
Patch RenderView's layout and computeLogicalWidth/Height methods to be block-flow-aware.
Attachments
Patch (25.38 KB, patch)
2010-09-27 15:30 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (21.16 KB, text/plain)
2010-09-27 15:33 PDT, Dave Hyatt 		no flags
Details
Patch (21.16 KB, patch)
2010-09-27 15:34 PDT, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch (21.13 KB, patch)
2010-09-27 15:35 PDT, Dave Hyatt 		sam: review-
DetailsFormatted DiffDiff
Patch (20.21 KB, patch)
2010-09-27 15:54 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-09-27 15:30:10 PDT
Created attachment 68974 [details] Patch
Dave Hyatt
Comment 2 2010-09-27 15:33:55 PDT
Created attachment 68976 [details] Patch
Dave Hyatt
Comment 3 2010-09-27 15:34:37 PDT
Created attachment 68977 [details] Patch
Dave Hyatt
Comment 4 2010-09-27 15:35:28 PDT
Created attachment 68978 [details] Patch
Sam Weinig
Comment 5 2010-09-27 15:52:22 PDT
Comment on attachment 68978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68978&action=review > WebCore/rendering/RenderBox.cpp:1737 > - else { > - if (style()->isVerticalBlockFlow()) > - visHeight = view()->viewHeight(); > - else > - visHeight = view()->viewWidth(); > - } > + else > + visHeight = view()->viewLogicalHeight(); I don't think this will end up using the correct style().
Dave Hyatt
Comment 6 2010-09-27 15:54:28 PDT
(In reply to comment #5) > (From update of attachment 68978 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68978&action=review > > > WebCore/rendering/RenderBox.cpp:1737 > > - else { > > - if (style()->isVerticalBlockFlow()) > > - visHeight = view()->viewHeight(); > > - else > > - visHeight = view()->viewWidth(); > > - } > > + else > > + visHeight = view()->viewLogicalHeight(); > > I don't think this will end up using the correct style(). Yeah I need to test more. The code change may be correct, but it's not clear to me if stretching turns off once you encounter a directionality change. I'll test in WinIE before patching that part.
Dave Hyatt
Comment 7 2010-09-27 15:54:58 PDT
Created attachment 68982 [details] Patch
Dave Hyatt
Comment 8 2010-09-27 15:58:52 PDT
Fixed in r68436.
Note You need to log in before you can comment on or make changes to this bug.