Bug 46753

Summary: Add -webkit-margin-before-collapse and -webkit-margin-after-collapse
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46123    
Attachments:
Description Flags
Patch sam: review+

Dave Hyatt
Reported 2010-09-28 14:03:12 PDT
Right now we have two properties named margin-top-collapse and margin-after-collapse. They are proprietary and only used by Safari RSS. I am adding margin-before-collapse and margin-after-collapse and just aliasing the old properties to the new ones. This way we have some names that are directionally independent. Note that these properties aren't like other directional properties. They are about what to do with the before side and after side of your block's margins when collapsing with adjacent blocks. The meaning of before/after depend on the block-flow directionality of the containing block.
Attachments
Patch (26.49 KB, patch)
2010-09-28 14:05 PDT, Dave Hyatt 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-09-28 14:05:04 PDT
Created attachment 69100 [details] Patch
Dave Hyatt
Comment 2 2010-09-28 14:17:03 PDT
Fixed in r68561.
Note You need to log in before you can comment on or make changes to this bug.