Bug 47021

Summary: Patch the floatBottom function and its friends.
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 46643    
Attachments:
Description Flags
Patch mitz: review+

Dave Hyatt
Reported 2010-10-01 15:15:19 PDT
Patch the floatBottom function and its friends. Rename them and consolidate them to be block-flow-aware.
Attachments
Patch (17.74 KB, patch)
2010-10-01 15:17 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2010-10-01 15:17:03 PDT
Created attachment 69526 [details] Patch
mitz
Comment 2 2010-10-01 15:51:34 PDT
Comment on attachment 69526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69526&action=review > WebCore/rendering/RenderBlock.cpp:3296 > -int > -RenderBlock::floatBottom() const > +int RenderBlock::lowestFloatLogicalBottom(FloatingObject::Type floatType) const Finally! > WebCore/rendering/RenderBlock.cpp:3304 > + if (r->type() & floatType) Kind of ugly. I’d like at least to see a comment about the definition of the FloatingObject::Type enum saying that it’s a bitfield.
mitz
Comment 3 2010-10-01 15:52:02 PDT
(In reply to comment #2) > I’d like at least to see a comment about the definition of the FloatingObject::Type enum saying that it’s a bitfield. s/about/above/
Dave Hyatt
Comment 4 2010-10-01 17:16:34 PDT
Fixed in r68957.
Note You need to log in before you can comment on or make changes to this bug.