Bug 49150

Summary: [GTK] LayoutTests/fast/events/spatial-navigation/snav-single-select.html fails on GTK
Product: WebKit Reporter: Chang Shu <cshu>
Component: FormsAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrobinson, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 47094    
Attachments:
Description Flags
fix patch
none
fix patch 2 none

Chang Shu
Reported 2010-11-07 17:53:22 PST
The above test works on Qt but fails on GTK. It also hangs on Mac but skipped. Most likely it's because of the different implementations of select box on different platforms.
Attachments
fix patch (2.15 KB, patch)
2010-11-08 11:53 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
fix patch 2 (3.26 KB, patch)
2010-11-08 12:32 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2010-11-08 07:38:12 PST
*** Bug 49176 has been marked as a duplicate of this bug. ***
Antonio Gomes
Comment 2 2010-11-08 07:39:44 PST
If a solution is not coming shortly, please skip it and unskip with the real patch.
Chang Shu
Comment 3 2010-11-08 07:42:39 PST
(In reply to comment #2) > If a solution is not coming shortly, please skip it and unskip with the real patch. sure, I will see if I can get it done by end of today.
Chang Shu
Comment 4 2010-11-08 11:53:26 PST
Created attachment 73259 [details] fix patch This could fix Mac, too. I will update the patch if this is the case.
Antonio Gomes
Comment 5 2010-11-08 12:04:27 PST
It looks nice. Could you please unskip the test in GTK+?
Chang Shu
Comment 6 2010-11-08 12:32:55 PST
Created attachment 73267 [details] fix patch 2
WebKit Commit Bot
Comment 7 2010-11-08 21:24:13 PST
Comment on attachment 73267 [details] fix patch 2 Clearing flags on attachment: 73267 Committed r71605: <http://trac.webkit.org/changeset/71605>
WebKit Commit Bot
Comment 8 2010-11-08 21:24:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.