Bug 51543

Summary: [Qt] Add fullscreen media control button for html video
Product: WebKit Reporter: Yi Shen <max.hong.shen>
Component: WebKit QtAssignee: Yi Shen <max.hong.shen>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue, nancy.piedra
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 35427, 51249, 52822    
Bug Blocks:    
Attachments:
Description Flags
first try
none
screenshot none

Yi Shen
Reported 2010-12-23 10:43:07 PST
Add a fullscreen button on the top right corner of the inline video element. When user clicks the fullscreen button, browser goes to fullscreen mode to playing the video.
Attachments
first try (2.63 KB, patch)
2011-01-26 16:37 PST, Yi Shen 		no flags
DetailsFormatted DiffDiff
screenshot (156.97 KB, image/png)
2011-01-26 16:40 PST, Yi Shen 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Yi Shen
Comment 1 2011-01-26 16:37:08 PST
Created attachment 80261 [details] first try
Yi Shen
Comment 2 2011-01-26 16:40:48 PST
Created attachment 80262 [details] screenshot
Andreas Kling
Comment 3 2011-01-26 16:59:14 PST
Comment on attachment 80261 [details] first try Palatial! r=me
WebKit Commit Bot
Comment 4 2011-01-27 17:23:29 PST
Comment on attachment 80261 [details] first try Clearing flags on attachment: 80261 Committed r76873: <http://trac.webkit.org/changeset/76873>
WebKit Commit Bot
Comment 5 2011-01-27 17:23:33 PST
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 6 2011-01-28 10:58:06 PST
This bug requires the changes from Bug 52822 (Clean up the Media Controls CSS for Qt) and Bug 35427 (trivial fix for missing default control) to be applied. I also have the impression that these changes would be welcome on the 2.1.x branch as we'll have to support video/audio media on 2.1.x for some time and these changes would be welcome. Yi: what do you think? Have you tested the changes from Bug 52822 and Bug 35427 on the 2.1.x branch? They look like low risk changes to me.
Yi Shen
Comment 7 2011-01-28 11:29:47 PST
(In reply to comment #6) > This bug requires the changes from Bug 52822 (Clean up the Media Controls CSS for Qt) and Bug 35427 (trivial fix for missing default control) to be applied. > > I also have the impression that these changes would be welcome on the 2.1.x branch as we'll have to support video/audio media on 2.1.x for some time and these changes would be welcome. > > Yi: what do you think? Have you tested the changes from Bug 52822 and Bug 35427 on the 2.1.x branch? They look like low risk changes to me. Hi, Ademar, I only have tested bug 52822 on html5-video-dev branch (http://gitorious.org/webkit/html5-video-dev) and it worked fine. I am agree with you that both changes are low risk and can be cherry-picked :)
Ademar Reis
Comment 8 2011-01-28 11:54:52 PST
Revision r76873 cherry-picked into qtwebkit-2.1.x with commit 138dcb6 <http://gitorious.org/webkit/qtwebkit/commit/138dcb6>
Note You need to log in before you can comment on or make changes to this bug.