Bug 53978

Summary: [EFL] Remove GDK dependency.
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, commit-queue, gyuyoung.kim, krit, leandro, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch
none
same_patch_for_efl_bot
none
Patch
none
Patch none

Ryuan Choi
Reported 2011-02-07 22:51:16 PST
WebKit/EFL can choose GLIB_SUPPORT because of many reason. However, I believe that WebKit/EFL doesn't need to have GDK dependency.
Attachments
Patch (2.54 KB, patch)
2011-02-07 23:16 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
same_patch_for_efl_bot (2.52 KB, patch)
2011-02-08 23:41 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (3.02 KB, patch)
2011-02-10 23:10 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (3.04 KB, patch)
2011-02-17 18:09 PST, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-02-07 23:16:17 PST
Created attachment 81593 [details] Patch
Ryuan Choi
Comment 2 2011-02-08 23:41:48 PST
Created attachment 81759 [details] same_patch_for_efl_bot
Dirk Schulze
Comment 3 2011-02-09 02:09:27 PST
Comment on attachment 81759 [details] same_patch_for_efl_bot Looks like the freetype fonts with cairo still need Gdk. Can you take a look at this please?
Ryuan Choi
Comment 4 2011-02-09 03:38:17 PST
(In reply to comment #3) > (From update of attachment 81759 [details]) > Looks like the freetype fonts with cairo still need Gdk. Can you take a look at this please? I don't know why, but efl bot try to build with PLATFORM(GTK). As following a build log, error position is what I removed EFL related macro for blocking GDK. I asked gyuyoung to solve. After resetting it, I'll try once more. Thank you.
Ryuan Choi
Comment 5 2011-02-10 23:10:19 PST
Created attachment 82105 [details] Patch
Ryuan Choi
Comment 6 2011-02-10 23:42:03 PST
(In reply to comment #5) > Created an attachment (id=82105) [details] > Patch gyuyoung, I don't know why it still failed. :( It is fine in my environment.
Gyuyoung Kim
Comment 7 2011-02-10 23:49:19 PST
Are you using "cmake ../Source -DPORT=Efl" command to build WebKit ? EFL EWS is using this build command, cd In Tools/Scripts ./build-webkit --efl --release --args="-j8" Could you build WebKit with above command ?
Ryuan Choi
Comment 8 2011-02-11 00:12:21 PST
(In reply to comment #7) > Are you using "cmake ../Source -DPORT=Efl" command to build WebKit ? yes. I use it. > > EFL EWS is using this build command, > > cd In Tools/Scripts > ./build-webkit --efl --release --args="-j8" > > Could you build WebKit with above command ? Tested, but I couldn't get build break.
Gyuyoung Kim
Comment 9 2011-02-11 00:29:15 PST
(In reply to comment #8) > (In reply to comment #7) > > Are you using "cmake ../Source -DPORT=Efl" command to build WebKit ? > > yes. I use it. > > > > > EFL EWS is using this build command, > > > > cd In Tools/Scripts > > ./build-webkit --efl --release --args="-j8" > > > > Could you build WebKit with above command ? > > Tested, but I couldn't get build break. Hmm, other patches are built by EWS successfully. Now, I don't know the reason :-(, let's find the reason.
Kent Tamura
Comment 10 2011-02-17 07:04:04 PST
Comment on attachment 82105 [details] Patch EFL EWS wasn't happy with this patch.
Dirk Schulze
Comment 11 2011-02-17 07:07:06 PST
(In reply to comment #10) > (From update of attachment 82105 [details]) > EFL EWS wasn't happy with this patch. Can someone else test the patch on his EFL machine? Strange if it works on one machine, but doesn't on the bot.
Gyuyoung Kim
Comment 12 2011-02-17 16:13:16 PST
(In reply to comment #11) > (In reply to comment #10) > > (From update of attachment 82105 [details] [details]) > > EFL EWS wasn't happy with this patch. > > Can someone else test the patch on his EFL machine? Strange if it works on one machine, but doesn't on the bot. There is no build error in other machine. EFLEWS has only build error. But, there was no build error when I built WebKit EFL with this patch in eflews machine. We are finding the reason. If this patch is landed to trunk, I think there is no problem. If there is build break, I will fix it as soon as possible.
Gyuyoung Kim
Comment 13 2011-02-17 16:52:04 PST
In EFLEWS, there is no build error with this patch. (I stoped eflews, then built WebKit EFL with this patch.) Could you please review "+" this patch ? I will monitor the efl buildbot as soon as this patch is landed.
Gyuyoung Kim
Comment 14 2011-02-17 17:26:21 PST
(In reply to comment #13) > In EFLEWS, there is no build error with this patch. (I stoped eflews, then built WebKit EFL with this patch.) > Could you please review "+" this patch ? > > I will monitor the efl buildbot as soon as this patch is landed. Ryuan, could you upload patch again ?
Ryuan Choi
Comment 15 2011-02-17 18:09:40 PST
Created attachment 82883 [details] Patch
Kent Tamura
Comment 16 2011-02-17 22:01:50 PST
Comment on attachment 82883 [details] Patch ok
Gyuyoung Kim
Comment 17 2011-02-17 22:07:19 PST
(In reply to comment #16) > (From update of attachment 82883 [details]) > ok Thank you for your review. I will see efl buildbot after landing this patch.
WebKit Commit Bot
Comment 18 2011-02-18 19:11:43 PST
The commit-queue encountered the following flaky tests while processing attachment 82883 [details]: media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 19 2011-02-18 19:13:29 PST
Comment on attachment 82883 [details] Patch Clearing flags on attachment: 82883 Committed r79069: <http://trac.webkit.org/changeset/79069>
WebKit Commit Bot
Comment 20 2011-02-18 19:13:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.