Bug 57156

Summary: RenderMedia should obey the view's flattening bit.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: MediaAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Jer Noble
Reported 2011-03-26 11:31:13 PDT
RenderMedia currently does not paint when the RenderView is drawing in flattening mode.
Attachments
Patch (1.50 KB, patch)
2011-03-26 12:08 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2011-03-26 12:32 PDT, Jer Noble 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-03-26 11:31:26 PDT
<rdar://problem/9028914>
Jer Noble
Comment 2 2011-03-26 11:35:54 PDT
Sorry, the FrameView (not the RenderView).
Jer Noble
Comment 3 2011-03-26 12:08:10 PDT
Created attachment 87034 [details] Patch
mitz
Comment 4 2011-03-26 12:13:08 PDT
Comment on attachment 87034 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87034&action=review > Source/WebCore/rendering/RenderVideo.cpp:205 > + else if (document()->view() && document()->view()->paintBehavior() == PaintBehaviorFlattenCompositingLayers) paintBehavior() is a bitmask, so you should check for (paintBehavior() & PaintBehaviorFlattenCompositingLayers)
Jer Noble
Comment 5 2011-03-26 12:18:19 PDT
(In reply to comment #4) > (From update of attachment 87034 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87034&action=review > > > Source/WebCore/rendering/RenderVideo.cpp:205 > > + else if (document()->view() && document()->view()->paintBehavior() == PaintBehaviorFlattenCompositingLayers) > > paintBehavior() is a bitmask, so you should check for (paintBehavior() & PaintBehaviorFlattenCompositingLayers) Good point. Changed.
mitz
Comment 6 2011-03-26 12:20:14 PDT
Comment on attachment 87034 [details] Patch r+ with the change
Jer Noble
Comment 7 2011-03-26 12:32:15 PDT
Created attachment 87038 [details] Patch
Jer Noble
Comment 8 2011-03-26 12:33:17 PDT
(In reply to comment #6) > (From update of attachment 87034 [details]) > r+ with the change Whoops, uploaded a new patch. Undoing. :)
Jer Noble
Comment 9 2011-03-26 12:34:02 PDT
TIL: obseleting a patch clears its flags. Would you mind r+'ing the new one?
Jer Noble
Comment 10 2011-03-26 16:22:28 PDT
Comment on attachment 87038 [details] Patch Clearing c+; preparing to commit manually.
Jer Noble
Comment 11 2011-03-26 16:47:27 PDT
Committed r82051: <http://trac.webkit.org/changeset/82051>
WebKit Commit Bot
Comment 12 2011-03-26 17:32:04 PDT
The commit-queue encountered the following flaky tests while processing attachment 87038 [details]: http/tests/websocket/tests/httponly-cookie.pl bug 54097 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.