Bug 57664

Summary: Stop preload scanning CSS when it's impossible to have another @import.
Product: WebKit Reporter: James Simonsen <simonjam>
Component: New BugsAssignee: James Simonsen <simonjam>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, koivisto, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch for landing none

James Simonsen
Reported 2011-04-01 14:51:51 PDT
Stop preload scanning CSS when it's impossible to have another @import.
Attachments
Patch (7.14 KB, patch)
2011-04-01 14:57 PDT, James Simonsen 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.20 KB, patch)
2011-04-04 15:06 PDT, James Simonsen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Simonsen
Comment 1 2011-04-01 14:57:14 PDT
Created attachment 87920 [details] Patch
Adam Barth
Comment 2 2011-04-01 15:07:04 PDT
Comment on attachment 87920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87920&action=review > Source/WebCore/html/parser/CSSPreloadScanner.cpp:68 > + if (isHTMLSpace(c)) > + { } Woah. That's how we usually do that. I'd have a separate if clause that just has a break in it. > Source/WebCore/html/parser/CSSPreloadScanner.cpp:90 > else if (c == '*') > - ; > + { } I'd also fix all of these. :)
James Simonsen
Comment 3 2011-04-01 15:23:15 PDT
webkit-patch upload complained. This is the way it told me to do it. I think it's referring to #4 under Braces in the style guide. I'll defer to your judgement though.
Adam Barth
Comment 4 2011-04-01 15:35:26 PDT
{ } is preferred to ; but we should avoid both if we can.
Adam Barth
Comment 5 2011-04-01 15:39:19 PDT
Comment on attachment 87920 [details] Patch As for the actual change, this looks great!
James Simonsen
Comment 6 2011-04-04 15:06:25 PDT
Created attachment 88139 [details] Patch for landing
WebKit Commit Bot
Comment 7 2011-04-05 02:26:18 PDT
The commit-queue encountered the following flaky tests while processing attachment 88139 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2011-04-05 02:28:15 PDT
Comment on attachment 88139 [details] Patch for landing Clearing flags on attachment: 88139 Committed r82916: <http://trac.webkit.org/changeset/82916>
WebKit Commit Bot
Comment 9 2011-04-05 02:28:20 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10 2011-04-05 03:50:45 PDT
http://trac.webkit.org/changeset/82916 might have broken GTK Linux 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.