Bug 62793

Summary: Add a function hasRenderer()
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: Layout and RenderingAssignee: Roland Steiner <rolandsteiner>
Status: RESOLVED INVALID    
Severity: Normal CC: ap, dglazkov, dominicc, hayato, krit, morrita, rwlbuis, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 62333    
Bug Blocks: 72352    
Attachments:
Description Flags
Patch none

Roland Steiner
Reported 2011-06-16 03:57:46 PDT
Currently, the function renderer() is used to both retrieve a node's renderer, as well as to simply check for the presence of a renderer (implicitly converting to bool). For future implementation changes, notably around SVG shadow tree implementations, separating the latter use-case out into a new function hasRenderer() would be helpful.
Attachments
Patch (200.51 KB, patch)
2011-06-16 04:24 PDT, Roland Steiner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2011-06-16 04:24:46 PDT
Created attachment 97435 [details] Patch
WebKit Review Bot
Comment 2 2011-06-16 04:27:23 PDT
Attachment 97435 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/editing/ReplaceSelectionCommand.cpp:151: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 1 in 111 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dimitri Glazkov (Google)
Comment 3 2011-06-16 08:41:37 PDT
Rob, Niko, Dirk -- this is a nice exploration of how much work we have ahead of us on making RenderObject multiplex on Node.
Dimitri Glazkov (Google)
Comment 4 2011-06-16 08:42:02 PDT
Comment on attachment 97435 [details] Patch Removing r?, since this is just an exploration at the moment.
Alexey Proskuryakov
Comment 5 2011-06-16 10:09:55 PDT
> For future implementation changes, notably around SVG shadow tree implementations, separating the latter use-case out into a new function hasRenderer() would be helpful. Does this mean that non-null renderer() result will not be equivalent to hasRenderer() returning true?
Hajime Morrita
Comment 6 2012-05-28 23:32:17 PDT
Closing - we have no concrete plan which relies on this.
Note You need to log in before you can comment on or make changes to this bug.