Bug 67137

Summary: Remove -webkit-mask-attachment
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: CSSAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, cmarcelo, eric, hyatt, krit, macpherson, menard, ojan, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 95389    
Attachments:
Description Flags
Patch
none
Patch
none
Patch hyatt: review+

Simon Fraser (smfr)
Reported 2011-08-29 10:25:30 PDT
-webkit-mask-attachment is not implemented. We should remove it.
Attachments
Patch (12.57 KB, patch)
2012-11-23 17:14 PST, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (15.96 KB, patch)
2012-11-23 19:24 PST, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Patch (17.72 KB, patch)
2012-11-23 20:23 PST, Dirk Schulze 		hyatt: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-08-29 10:49:32 PDT
Hmm, we might have to keep it so that the -webkit-mask shorthand parses just like background.
Alexis Menard (darktears)
Comment 2 2012-01-17 05:52:02 PST
It seems that -webkit-mask-attachment is implemented. I find various occurrence of it in CSSParser, CSSMutableStyleDeclaration and CSSComputedStyleDeclaration. What is exactly not implemented?
Simon Fraser (smfr)
Comment 3 2012-01-17 09:10:20 PST
The painting side is not implemented.
Dirk Schulze
Comment 4 2012-11-21 22:05:51 PST
(In reply to comment #1) > Hmm, we might have to keep it so that the -webkit-mask shorthand parses just like background. This is actually not the biggest problem. The -webkit-mask property differs from background property already. CSS Masking removed it from the specification definition as well. I would like to go ahead and remove it. Are there concerns that content could be broken when we change the syntax? Note, computed style for -webkit-mask is not implemented either.
Dirk Schulze
Comment 5 2012-11-23 17:14:56 PST
Created attachment 175841 [details] Patch
Dirk Schulze
Comment 6 2012-11-23 19:24:56 PST
Created attachment 175845 [details] Patch
Dirk Schulze
Comment 7 2012-11-23 20:23:48 PST
Created attachment 175848 [details] Patch
Dirk Schulze
Comment 8 2012-11-23 20:26:05 PST
I verified that all other failing tests are unrelated to this patch. Again, even if this removes the property -webkit-mask-attachment, I doubt that this will have affect on content. This property was never supported in WebCore. The property was just visible in CSSOM without any affect on the rendering.
Dave Hyatt
Comment 9 2012-11-28 13:45:19 PST
Comment on attachment 175848 [details] Patch r=me
Dirk Schulze
Comment 10 2012-11-28 18:04:36 PST
Committed r136080: <http://trac.webkit.org/changeset/136080>
Note You need to log in before you can comment on or make changes to this bug.