Bug 69848

Summary:

[CSS Regions]Remove -webkit-content-order property

Product:

WebKit

Reporter:

Mihnea Ovidenie <mihnea>

Component:

CSS

Assignee:

Mihnea Ovidenie <mihnea>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, tomz, tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

69752

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	mihnea: commit-queue-
Patch for landing	none
Patch for landing	none

Mihnea Ovidenie

Reported 2011-10-11 10:03:04 PDT

Latest version of the regions spec removes this property: http://dev.w3.org/csswg/css3-regions/

Attachments
Patch (80.69 KB, patch) 2011-10-11 10:09 PDT, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Patch for landing (91.94 KB, patch) 2011-10-11 23:36 PDT, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Patch for landing (91.96 KB, patch) 2011-10-12 04:48 PDT, Mihnea Ovidenie	mihnea: commit-queue-	Details Formatted Diff Diff
Patch for landing (86.78 KB, patch) 2011-10-12 05:08 PDT, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Patch for landing (95.20 KB, patch) 2011-10-12 14:26 PDT, Tony Chang	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Mihnea Ovidenie

Comment 1 2011-10-11 10:09:15 PDT

Created attachment 110530 [details] Patch

Tony Chang

Comment 2 2011-10-11 10:32:40 PDT

Comment on attachment 110530 [details] Patch Do you know why the patch doesn't apply?

Mihnea Ovidenie

Comment 3 2011-10-11 23:36:27 PDT

Created attachment 110645 [details] Patch for landing

WebKit Review Bot

Comment 4 2011-10-11 23:36:51 PDT

Comment on attachment 110645 [details] Patch for landing Rejecting attachment 110645 [details] from commit-queue. mihnea@adobe.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

Mihnea Ovidenie

Comment 5 2011-10-12 04:48:34 PDT

Created attachment 110667 [details] Patch for landing

Mihnea Ovidenie

Comment 6 2011-10-12 05:08:16 PDT

Created attachment 110670 [details] Patch for landing

WebKit Review Bot

Comment 7 2011-10-12 07:10:16 PDT

Comment on attachment 110670 [details] Patch for landing Rejecting attachment 110670 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: tyle/computed-style-without-renderer.html = TEXT fast/css/getComputedStyle/computed-style.html = TEXT svg/css/getComputedStyle-basic.xhtml = TEXT Regressions: Unexpected image mismatch : (5) fast/text/atsui-multiple-renderers.html = IMAGE fast/text/international/danda-space.html = IMAGE fast/text/international/thai-baht-space.html = IMAGE fast/text/international/thai-line-breaks.html = IMAGE platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE Full output: http://queues.webkit.org/results/10030882

WebKit Review Bot

Comment 8 2011-10-12 11:25:59 PDT

Tony Chang

Comment 9 2011-10-12 11:31:52 PDT

I'm not sure why this patch is failing. @abarth: I thought the cq would automatically ignore the failures from not having the right fonts installed. Do you know why that's no longer happening?

Adam Barth

Comment 10 2011-10-12 11:50:17 PDT

> @abarth: I thought the cq would automatically ignore the failures from not having the right fonts installed. Do you know why that's no longer happening? Sorry the error messages from the commit-queue aren't very good. It looks like this patch causes these tests to fail: Regressions: Unexpected text diff mismatch : (3) fast/css/getComputedStyle/computed-style-without-renderer.html = TEXT fast/css/getComputedStyle/computed-style.html = TEXT svg/css/getComputedStyle-basic.xhtml = TEXT

Tony Chang

Comment 11 2011-10-12 11:52:20 PDT

(In reply to comment #10) > > @abarth: I thought the cq would automatically ignore the failures from not having the right fonts installed. Do you know why that's no longer happening? > > Sorry the error messages from the commit-queue aren't very good. It looks like this patch causes these tests to fail: > > Regressions: Unexpected text diff mismatch : (3) > fast/css/getComputedStyle/computed-style-without-renderer.html = TEXT > fast/css/getComputedStyle/computed-style.html = TEXT > svg/css/getComputedStyle-basic.xhtml = TEXT I see, the patch is just missing the chromium baselines for these. I guess there's no way to force the cq to land the patch and grab the baselines from the bots manually so we need to add it to LayoutTests/platform/chromium/test_expectations.txt in this patch.

Mihnea Ovidenie

Comment 12 2011-10-12 12:03:41 PDT

(In reply to comment #11) > (In reply to comment #10) > > > @abarth: I thought the cq would automatically ignore the failures from not having the right fonts installed. Do you know why that's no longer happening? > > > > Sorry the error messages from the commit-queue aren't very good. It looks like this patch causes these tests to fail: > > > > Regressions: Unexpected text diff mismatch : (3) > > fast/css/getComputedStyle/computed-style-without-renderer.html = TEXT > > fast/css/getComputedStyle/computed-style.html = TEXT > > svg/css/getComputedStyle-basic.xhtml = TEXT > > I see, the patch is just missing the chromium baselines for these. I guess there's no way to force the cq to land the patch and grab the baselines from the bots manually so we need to add it to LayoutTests/platform/chromium/test_expectations.txt in this patch. Ok, so i need to modify test_expectations.txt in this patch to mark that the above files are failing for this bug? Something like: BUGWK69848 : fast/css/getComputedStyle/computed-style-without-renderer.html = FAIL If this is the right approach, i will redo the patch and put it in the commit queue again.

Tony Chang

Comment 13 2011-10-12 12:22:21 PDT

(In reply to comment #12) > Ok, so i need to modify test_expectations.txt in this patch to mark that the above files are failing for this bug? Something like: > BUGWK69848 : fast/css/getComputedStyle/computed-style-without-renderer.html = FAIL > > If this is the right approach, i will redo the patch and put it in the commit queue again. Yes, that's right. Make sure to run new-run-webkit-tests --chromium --lint-test-files to make sure the syntax is correct.

WebKit Review Bot

Comment 14 2011-10-12 14:17:44 PDT

Comment on attachment 110670 [details] Patch for landing Attachment 110670 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10040047 New failing tests: svg/css/getComputedStyle-basic.xhtml fast/css/getComputedStyle/computed-style.html fast/css/getComputedStyle/computed-style-without-renderer.html

Tony Chang

Comment 15 2011-10-12 14:22:28 PDT

Actually, I bet I can hand edit the results. I'll try that.

Tony Chang

Comment 16 2011-10-12 14:26:50 PDT

Created attachment 110746 [details] Patch for landing

WebKit Review Bot

Comment 17 2011-10-12 15:13:44 PDT

Comment on attachment 110746 [details] Patch for landing Clearing flags on attachment: 110746 Committed r97308: <http://trac.webkit.org/changeset/97308>

WebKit Review Bot

Comment 18 2011-10-12 15:13:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.