Bug 70014

Summary: [CSS Regions] Change -webkit-flow to -webkit-flow-into
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 69752    
Attachments:
Description Flags
Patch
none
Patch 2
none
Patch for landing none

Mihnea Ovidenie
Reported 2011-10-13 03:55:57 PDT
1. -webkit-flow is renamed to -webkit-flow-into 2. -webkit-flow-into takes <ident> instead of strings
Attachments
Patch (63.10 KB, patch)
2011-10-13 03:59 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch 2 (63.15 KB, patch)
2011-10-13 04:40 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Patch for landing (69.47 KB, patch)
2011-10-14 01:09 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2011-10-13 03:59:34 PDT
Created attachment 110822 [details] Patch
WebKit Review Bot
Comment 2 2011-10-13 04:01:49 PDT
Attachment 110822 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] LayoutTests/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/WebCore/css/CSSParser.cpp:6512: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/css/CSSParser.cpp:6513: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/css/CSSParser.cpp:6514: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Source/WebCore/css/CSSParser.cpp:6515: Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side. [whitespace/operators] [4] Total errors found: 8 in 79 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mihnea Ovidenie
Comment 3 2011-10-13 04:40:56 PDT
Created attachment 110825 [details] Patch 2 Correct webkit style.
Dave Hyatt
Comment 4 2011-10-13 13:39:13 PDT
Comment on attachment 110825 [details] Patch 2 r=me, but won't pass commit queue so clearing that. You'll need to patch the new tests as well, but assume you have a blanket r+ as long as you're just changing tests.
Mihnea Ovidenie
Comment 5 2011-10-14 01:09:45 PDT
Created attachment 110973 [details] Patch for landing
WebKit Review Bot
Comment 6 2011-10-14 02:27:57 PDT
Comment on attachment 110973 [details] Patch for landing Clearing flags on attachment: 110973 Committed r97454: <http://trac.webkit.org/changeset/97454>
WebKit Review Bot
Comment 7 2011-10-14 02:28:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.