Bug 72938

Summary: Use more macrology in JSC::Options
Product: WebKit Reporter: Andy Wingo <wingo>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, fpizlo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 72889    
Bug Blocks: 74498    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Andy Wingo
Reported 2011-11-22 04:14:35 PST
Use more macrology in JSC::Options
Attachments
Patch (11.75 KB, patch)
2011-11-22 04:17 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Patch (11.75 KB, patch)
2011-11-22 04:26 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Patch (10.11 KB, patch)
2011-11-29 09:10 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Patch (10.16 KB, patch)
2011-11-29 09:50 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Patch (10.56 KB, patch)
2011-12-12 03:19 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Patch (10.94 KB, patch)
2011-12-15 06:23 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Andy Wingo
Comment 1 2011-11-22 04:17:44 PST
Created attachment 116200 [details] Patch
Andy Wingo
Comment 2 2011-11-22 04:21:59 PST
Of course, I look over the patch 10 times, but only notice a error after uploading. Pushing a fix shortly.
Andy Wingo
Comment 3 2011-11-22 04:26:38 PST
Created attachment 116201 [details] Patch
Filip Pizlo
Comment 4 2011-11-22 13:39:53 PST
Ahhh, this looks good. I'll r+ once the other patch lands and we can see that the bots are happy.
Andy Wingo
Comment 5 2011-11-29 09:10:09 PST
Created attachment 116980 [details] Patch
Andy Wingo
Comment 6 2011-11-29 09:50:02 PST
Created attachment 116987 [details] Patch
Andy Wingo
Comment 7 2011-12-12 03:19:22 PST
Created attachment 118762 [details] Patch
Andy Wingo
Comment 8 2011-12-15 06:23:53 PST
Created attachment 119418 [details] Patch
Andy Wingo
Comment 9 2011-12-15 06:24:33 PST
Comment on attachment 119418 [details] Patch Same patch, resubmitted to give EWS a crack at it
WebKit Review Bot
Comment 10 2011-12-15 13:29:52 PST
Comment on attachment 119418 [details] Patch Clearing flags on attachment: 119418 Committed r102978: <http://trac.webkit.org/changeset/102978>
WebKit Review Bot
Comment 11 2011-12-15 13:29:57 PST
All reviewed patches have been landed. Closing bug.
Filip Pizlo
Comment 12 2011-12-18 00:51:52 PST
This was a bad idea. Now if I want to change one of the options, I have to wait for the whole world to rebuild.
Andy Wingo
Comment 13 2011-12-18 03:41:06 PST
(In reply to comment #12) > This was a bad idea. Now if I want to change one of the options, I have to wait for the whole world to rebuild. Ah, bummer. OTOH with the command-line patch from 74498, you can do so at runtime. Doesn't solve this issue, though.
Note You need to log in before you can comment on or make changes to this bug.