Bug 73085

Summary: [chromium] composited layers are not invalidated correctly with a zoom-in page scale factor
Product: WebKit Reporter: Grace Kloba <klobag>
Component: New BugsAssignee: Grace Kloba <klobag>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: abarth, cc-bugs, fsamuel, hclam, husky, jamesr, peter, skyostil, skyostil, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch jamesr: review-

Grace Kloba
Reported 2011-11-24 09:51:14 PST
This is the side effect of https://bugs.webkit.org/show_bug.cgi?id=71225. When page scale factor is greater than one, the invalidation area is not scale correctly. This caused some area are not updated correct when it needs.
Attachments
Patch (5.11 KB, patch)
2011-11-29 17:00 PST, Grace Kloba 		jamesr: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Grace Kloba
Comment 1 2011-11-29 17:00:11 PST
Created attachment 117074 [details] Patch
James Robinson
Comment 2 2011-11-29 17:02:46 PST
Comment on attachment 117074 [details] Patch Need a test!
Dana Jansens
Comment 3 2012-07-18 06:44:57 PDT
Comment on attachment 117074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117074&action=review > Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:684 > - return pageScaleFactor() * deviceScaleFactor(); > + return pageScaleFactor(); This is going to break ChromeOS, where pageScaleFactor is 1 but deviceScaleFactor is not (see NonCompositedContentHost.h)
Dana Jansens
Comment 4 2012-07-18 06:46:16 PDT
Comment on attachment 117074 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=117074&action=review >> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:684 >> + return pageScaleFactor(); > > This is going to break ChromeOS, where pageScaleFactor is 1 but deviceScaleFactor is not (see NonCompositedContentHost.h) Also, note that deviceScaleFactor() would be 1 on non-ChromeOS already (see WebViewImpl.cpp:3685)
Sami Kyöstilä
Comment 5 2012-07-18 06:52:38 PDT
I wonder if this is related: https://bugs.webkit.org/show_bug.cgi?id=88762
Adam Barth
Comment 6 2012-10-17 12:56:31 PDT
This patch appears to no longer be needed.
Note You need to log in before you can comment on or make changes to this bug.