Bug 73942

Summary: webkitpy provides no way to specify the PID of the crashed process whose crash log you want to find
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71380    
Attachments:
Description Flags
Patch dpranke: review+

Adam Roben (:aroben)
Reported 2011-12-06 11:54:56 PST
webkitpy provides no way to specify the PID of the crashed process whose crash log you want to find
Attachments
Patch (10.08 KB, patch)
2011-12-06 11:59 PST, Adam Roben (:aroben) 		dpranke: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-12-06 11:59:29 PST
Created attachment 118086 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-12-06 12:04:46 PST
Committed r102163: <http://trac.webkit.org/changeset/102163>
Eric Seidel (no email)
Comment 3 2011-12-06 14:15:35 PST
Comment on attachment 118086 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=118086&action=review > Tools/ChangeLog:17 > + (CrashLogs.find_newest_log): Added an optional pid parameter. > + (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each > + candidate log's app_description extended attribute to see if that log corresponds to a > + crashed process with the specified PID. I'm surprised you do this via xattr instead of just parsing the text files.
Eric Seidel (no email)
Comment 4 2011-12-06 14:15:51 PST
Does this work on SL as well as Lion?
Adam Roben (:aroben)
Comment 5 2011-12-06 20:37:19 PST
(In reply to comment #3) > I'm surprised you do this via xattr instead of just parsing the text files. I figured xattr would be faster. (In reply to comment #4) > Does this work on SL as well as Lion? Looks like Snow Leopard doesn't set any attributes that contain the PID. :-(
Adam Roben (:aroben)
Comment 6 2011-12-08 08:30:10 PST
Thanks for pointing that out, Eric. Bug 74094 contains a fix.
Note You need to log in before you can comment on or make changes to this bug.