Bug 74315

Summary:

[CSSRegions]Revert RenderObject::style() to its state before region styling

Product:

WebKit

Reporter:

Mihnea Ovidenie <mihnea>

Component:

CSS

Assignee:

Mihnea Ovidenie <mihnea>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

tony, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	webkit.review.bot: commit-queue-

Mihnea Ovidenie

Reported 2011-12-12 12:13:04 PST

The region styling patch adding support for background color (https://bugs.webkit.org/show_bug.cgi?id=71488) introduced a regression in performance (https://bugs.webkit.org/show_bug.cgi?id=74141). I am reverting RenderObject::style() to its shape before the region styling patch.

Attachments
Patch (3.51 KB, patch) 2011-12-12 13:39 PST, Mihnea Ovidenie	no flags	Details Formatted Diff Diff
Patch for landing (2.67 KB, patch) 2011-12-12 14:43 PST, Mihnea Ovidenie	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mihnea Ovidenie

Comment 1 2011-12-12 13:39:21 PST

Created attachment 118834 [details] Patch

Tony Chang

Comment 2 2011-12-12 13:40:56 PST

thanks!

WebKit Review Bot

Comment 3 2011-12-12 13:42:47 PST

Attachment 118834 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1 ERROR: FAILURES FOR <lucid, x86_64, release, cpu> in LayoutTests/platform/chromium/test_expectations.txt ERROR: Line:3249 Duplicate or ambiguous expectation. fast/regions/region-style-block-background-color.html ERROR: Line:3250 Duplicate or ambiguous expectation. fast/regions/region-style-block-background-color2.html ERROR: Line:3251 Duplicate or ambiguous expectation. fast/regions/region-style-image-background-color.html ERROR: Line:3252 Duplicate or ambiguous expectation. fast/regions/region-style-inline-background-color.html LayoutTests/platform/chromium/test_expectations.txt:3249: Duplicate or ambiguous expectation. fast/regions/region-style-block-background-color.html [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3250: Duplicate or ambiguous expectation. fast/regions/region-style-block-background-color2.html [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3251: Duplicate or ambiguous expectation. fast/regions/region-style-image-background-color.html [test/expectations] [5] LayoutTests/platform/chromium/test_expectations.txt:3252: Duplicate or ambiguous expectation. fast/regions/region-style-inline-background-color.html [test/expectations] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Mihnea Ovidenie

Comment 4 2011-12-12 14:43:02 PST

Created attachment 118852 [details] Patch for landing

WebKit Review Bot

Comment 5 2011-12-12 16:41:53 PST

Comment on attachment 118852 [details] Patch for landing Rejecting attachment 118852 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: T (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Prefix internal methods in Objective-C API files with an underscore When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 158. Full output: http://queues.webkit.org/results/10848127

Tony Chang

Comment 6 2011-12-12 16:56:34 PST

Committed r102641: <http://trac.webkit.org/changeset/102641>

Note You need to log in before you can comment on or make changes to this bug.