Bug 77144

Summary: run-perf-test should include relative file paths in test names
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, morrita, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
fixes the bug abarth: review+

Ryosuke Niwa
Reported 2012-01-26 14:51:20 PST
Right now, run-perf-test only uses the filename as the test name but this won't scale when we add more perf tests.
Attachments
fixes the bug (3.42 KB, patch)
2012-01-26 15:29 PST, Ryosuke Niwa 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-01-26 15:29:18 PST
Created attachment 124192 [details] fixes the bug
Adam Barth
Comment 2 2012-01-26 15:39:39 PST
Comment on attachment 124192 [details] fixes the bug ok. How MacOS 9 of you!
Dirk Pranke
Comment 3 2012-01-26 15:48:20 PST
Comment on attachment 124192 [details] fixes the bug Do we have to follow the chromium perf bot convention? It would seem better to follow the webkit conventions for test names and use '/'.
Ryosuke Niwa
Comment 4 2012-01-26 15:55:18 PST
(In reply to comment #3) > (From update of attachment 124192 [details]) > Do we have to follow the chromium perf bot convention? It would seem better to follow the webkit conventions for test names and use '/'. We could but we don't have to match layout tests' convention either though. Is there any reason using '/' as the delimiter is better?
Dirk Pranke
Comment 5 2012-01-26 16:06:58 PST
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 124192 [details] [details]) > > Do we have to follow the chromium perf bot convention? It would seem better to follow the webkit conventions for test names and use '/'. > > We could but we don't have to match layout tests' convention either though. Is there any reason using '/' as the delimiter is better? It seems to me that having a single convention used by the tools in a single code base would be better. That way I don't have to remember that it's run-webkit-tests fast/html but run-perf-tests fast:html . I type this now realizing that what is in the JSON file is not necessarily what's on the command line, but it seems to me that being uniform is good, and if test names get displayed on a web page I would want them to display as "/" to match the other tools. If the chromium perf test store "foo:bar" but display "foo/bar", then ":" is fine by me.
Dirk Pranke
Comment 6 2012-01-26 16:07:52 PST
(In reply to comment #5) > If the chromium perf test store "foo:bar" but display "foo/bar", then ":" is fine by me. Well, "fine" might be a bit strong; I'd probably still grumble a little over it being different :).
Ryosuke Niwa
Comment 7 2012-01-26 16:28:53 PST
I guess being able to copy & paste test name is a strong argument. Will change it to /.
Ryosuke Niwa
Comment 8 2012-01-26 19:50:01 PST
http://trac.webkit.org/changeset/106062
Note You need to log in before you can comment on or make changes to this bug.