Bug 77328

Summary: Import Dromaeo to WebKit repository
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: Tools / TestsAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, kling, koivisto, rniwa, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 76156    
Attachments:
Description Flags
Patch - Uploading manually because it's too big.
none
Updated Patch
none
Removed BSD-licensed files. none

Hajime Morrita
Reported 2012-01-30 04:12:05 PST
I'm planning to pull the dromaeo repo somewhere before run. It might be better to have a fork in the repo though. I have no strong preference here. A modified version is here: https://github.com/omo/dromaeo I'm going to ask the upstream to pull this once it runs well.
Attachments
Patch - Uploading manually because it's too big. (deleted)
2012-01-31 02:50 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Updated Patch (deleted)
2012-01-31 16:52 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Removed BSD-licensed files. (deleted)
2012-01-31 17:19 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-01-30 09:24:35 PST
I think it's better to have a copy in the repository. I don't wanna see us re-creating the gclient nightmare.
Adam Barth
Comment 2 2012-01-30 11:46:24 PST
How big is Dromaeo?
Ryosuke Niwa
Comment 3 2012-01-30 11:56:36 PST
About 10MB but test themselves are only 3.5MB: https://github.com/jeresig/dromaeo
Adam Barth
Comment 4 2012-01-30 12:00:28 PST
3.5 MB sounds fine to import wholesale.
Hajime Morrita
Comment 5 2012-01-30 16:35:12 PST
(In reply to comment #4) > 3.5 MB sounds fine to import wholesale. I thought we should pull it from the original source to make update easy. But maybe it's OK to have our own copy seeing Dromaeo doesn't have any big change these days. I'll take that way.
Ryosuke Niwa
Comment 6 2012-01-30 16:37:33 PST
(In reply to comment #5) > I thought we should pull it from the original source to make update easy. > But maybe it's OK to have our own copy seeing Dromaeo doesn't have any big change these days. > I'll take that way. I think importing will be better. For example, if we decide to import newer version of Dromaeo in the future, we can put in a separate directory in order to run both versions for a while.
Hajime Morrita
Comment 7 2012-01-31 02:50:53 PST
Created attachment 124693 [details] Patch - Uploading manually because it's too big.
WebKit Review Bot
Comment 8 2012-01-31 02:56:10 PST
Attachment 124693 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9 Updating OpenSource First, rewinding head to replay your work on top of it... Applying: Fix compilation errors on build-webkit --debug --no-workers on mac. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging LayoutTests/ChangeLog CONFLICT (content): Merge conflict in LayoutTests/ChangeLog Auto-merging LayoutTests/platform/qt/Skipped CONFLICT (content): Merge conflict in LayoutTests/platform/qt/Skipped Auto-merging Source/WebCore/ChangeLog CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Fix compilation errors on build-webkit --debug --no-workers on mac. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 9 2012-01-31 12:28:46 PST
JSON.php is licensed under old BSD license, which is NOT compatible with GPL. So we can't land this as is. But given these aren't http tests, we don't need it, right? also, we probably don't need json.js since WebKit implements JSON.
Ryosuke Niwa
Comment 10 2012-01-31 12:51:20 PST
Alos, you may need to update some files after http://trac.webkit.org/changeset/106379.
Hajime Morrita
Comment 11 2012-01-31 16:52:20 PST
Created attachment 124849 [details] Updated Patch
Hajime Morrita
Comment 12 2012-01-31 16:55:35 PST
Oops the patch was wrong. But I cannot obsolete it because the page cannot finish loading.
Hajime Morrita
Comment 13 2012-01-31 17:19:36 PST
Created attachment 124857 [details] Removed BSD-licensed files.
Hajime Morrita
Comment 14 2012-01-31 17:22:01 PST
- The style errors are false positive. they came from third party libraries. - The bots failed to apply the patch because it was too big for them.
Ryosuke Niwa
Comment 15 2012-01-31 17:52:17 PST
r=me Unfortunately, the stupid iframe in Details page is preventing me from setting r+ so I can't set the flag on the actual patch.
Hajime Morrita
Comment 16 2012-01-31 19:52:02 PST
Committed r106425: <http://trac.webkit.org/changeset/106425>
Note You need to log in before you can comment on or make changes to this bug.