Bug 77591

Summary: Replace [CustomPrototypeDefineGetter] with [CustomDefineGetter]
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, darin, gustavo.noronha, gustavo, japhet, ojan, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch abarth: review+, webkit-ews: commit-queue-

Kentaro Hara
Reported 2012-02-01 18:15:19 PST
[CustomPrototypeDefineGetter] is implemented in CodeGeneratorJS.pm only, and it has the same meaning as [CustomDefineGetter]. We can replace [CustomPrototypeDefineGetter] with [CustomDefineGetter].
Attachments
Patch (2.52 KB, patch)
2012-02-01 18:18 PST, Kentaro Hara 		abarth: review+
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-01 18:18:00 PST
Created attachment 125059 [details] Patch
Adam Barth
Comment 2 2012-02-01 18:42:36 PST
Comment on attachment 125059 [details] Patch Yeah, certainly looks the same.
Early Warning System Bot
Comment 3 2012-02-01 19:11:21 PST
Comment on attachment 125059 [details] Patch Attachment 125059 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11387710
Gyuyoung Kim
Comment 4 2012-02-01 19:54:50 PST
Comment on attachment 125059 [details] Patch Attachment 125059 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11388687
Collabora GTK+ EWS bot
Comment 5 2012-02-02 04:53:01 PST
Comment on attachment 125059 [details] Patch Attachment 125059 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11386792
Kentaro Hara
Comment 6 2012-02-03 03:10:29 PST
Sorry, the patch was wrong. [CustomDefineGetter] and [CustomPrototypeDefineGetter] are different. The former declares defineGetter() on an interface class (e.g. JSLocation), and the latter declares defineGetter() on a prototype interface class (e.g. JSLocationPrototype). Let me mark this bug as WONTFIX.
Note You need to log in before you can comment on or make changes to this bug.