Bug 77770

Summary: [chromium] Use explicit casts for WebRect/WebSize to IntRect/IntSize conversions
Product: WebKit Reporter: Emil A Eklund <eae>
Component: WebKit Misc.Assignee: Emil A Eklund <eae>
Status: RESOLVED WONTFIX    
Severity: Normal CC: aroben, eric, fishd, leviw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 71143    
Attachments:
Description Flags
Patch none

Emil A Eklund
Reported 2012-02-03 13:17:09 PST
With the introduction of FixedRect/Size/Point the implicit conversion path from WebRect to IntRect is no longer unambiguous.
Attachments
Patch (4.32 KB, patch)
2012-02-03 13:33 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-02-03 13:33:56 PST
Created attachment 125399 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-03 14:03:08 PST
Comment on attachment 125399 [details] Patch I'm not sure what this buys us. It's nice that these implicitly convert. What benifit of removed ambiguity is there? Or was this just helpful to you while writing your layout patch (as I assume you may have removed the implicit constructors to find all the callsites and check them?)
Emil A Eklund
Comment 3 2012-02-03 14:04:59 PST
It avoids "ambiguous conversion" compiler errors when building with the sub pixel units on certain platforms, most notably windows.
Eric Seidel (no email)
Comment 4 2012-02-03 14:08:44 PST
I see. Could you tell me which conversions it thinks are ambigious? As in could you paste either an example warning (or a made up one?) Just so I understand what I'd be approving here. :)
Eric Seidel (no email)
Comment 5 2012-02-03 14:09:25 PST
Given that thsi is chromium only, I probably should remove the various apple folks I CC'd. Sorry for the bug spam.
Emil A Eklund
Comment 6 2012-02-03 14:32:36 PST
> I see. Could you tell me which conversions it thinks are ambigious? As in could you paste either an example warning (or a made up one?) Of course, I'll kick off a build without these changes right away and report back.
Emil A Eklund
Comment 7 2012-02-08 13:32:33 PST
As we no longer have implicit conversion between FixedRect/Point/Size and platform specific types this patch is now obsolete.
Note You need to log in before you can comment on or make changes to this bug.