Bug 77970

Summary: Remove the [ReplaceableConstructor] IDL attribute
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: abarth, ashvayka, darin, eric, japhet, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch eric: review+, haraken: commit-queue-

Kentaro Hara
Reported 2012-02-07 04:58:42 PST
It would make sense to replace the [ReplaceableConstructor] attribute with "DOMWindow" for the following reasons: - The [ReplaceableConstructor] attribute is used by JSC's DOMWindow.idl only. - CodeGeneratorJS.pm supports the [ReplaceableConstructor] attribute for DOMWindow.idl only (If we use [RepaceableConstructor] in other IDL files, then CodeGeneratorJS.pm dies). - DOMWindow is already handled specially here and there in code generators.
Attachments
Patch (4.31 KB, patch)
2012-02-07 05:01 PST, Kentaro Hara 		eric: review+
haraken: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-07 05:01:51 PST
Created attachment 125820 [details] Patch
Eric Seidel (no email)
Comment 2 2012-02-07 16:00:00 PST
Comment on attachment 125820 [details] Patch Seems reasonable.
Kentaro Hara
Comment 3 2012-02-07 16:02:24 PST
Comment on attachment 125820 [details] Patch Eric: Thanks for review. In bug 77966, we have been discussing how hard-coded "DOMWindow" in code generators should be removed. Let me commit the patch after that discussion.
Alexey Shvayka
Comment 4 2021-08-04 17:16:08 PDT
[ReplaceableConstructor] was removed in r190085, as part of %Interface%.prototype.constructor attributes fix. *** This bug has been marked as a duplicate of bug 149412 ***
Note You need to log in before you can comment on or make changes to this bug.