Bug 78278

Summary: [BlackBerry] Upstream graphics helper classes in WebKitSupport
Product: WebKit Reporter: Rob Buis <rwlbuis>
Component: New BugsAssignee: Rob Buis <rwlbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jpetsovits, manyoso, ojan, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch tonikitoo: review+

Rob Buis
Reported 2012-02-09 13:29:56 PST
Upstream graphics helper classes in WebKitSupport
Attachments
Patch (8.23 KB, patch)
2012-02-09 13:31 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (16.98 KB, patch)
2012-02-09 14:43 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (16.22 KB, patch)
2012-02-09 18:36 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (15.79 KB, patch)
2012-02-10 07:20 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (42.63 KB, patch)
2012-02-10 11:23 PST, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (42.59 KB, patch)
2012-02-10 11:59 PST, Rob Buis 		tonikitoo: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2012-02-09 13:31:45 PST
Created attachment 126360 [details] Patch
Rob Buis
Comment 2 2012-02-09 13:36:32 PST
Add Antonio.
Antonio Gomes
Comment 3 2012-02-09 14:37:03 PST
Comment on attachment 126360 [details] Patch you probably uploaded the wrong patch. WebPageCompositor is here: bug 78276
Rob Buis
Comment 4 2012-02-09 14:43:02 PST
Created attachment 126376 [details] Patch
Antonio Gomes
Comment 5 2012-02-09 15:10:55 PST
jakob/adam, do we want to upstream #if OPENVG blocks of code, or stick with SKIA only?
Jakob Petsovits
Comment 6 2012-02-09 15:15:32 PST
I think we want to avoid upstreaming them, and suggest removal of OpenVG from the tree as it's not a focus for us anymore.
Antonio Gomes
Comment 7 2012-02-09 16:21:38 PST
Comment on attachment 126376 [details] Patch lets set us free of openvg first :-)
Rob Buis
Comment 8 2012-02-09 18:36:53 PST
Created attachment 126425 [details] Patch
Antonio Gomes
Comment 9 2012-02-09 19:12:56 PST
Comment on attachment 126425 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126425&action=review some more comments and questions ... > Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:109 > +#if USE(SKIA) > + WebCore::PlatformContextSkia* platformGraphicsContext = new WebCore::PlatformContextSkia(drawable); > +#endif > + return platformGraphicsContext; that wont build if !SKIA > Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:119 > +PlatformGraphicsContext* SurfacePool::lockTileRenderingSurface() const > +{ > +#if USE(SKIA) > + if (!m_tileRenderingSurface) > + return 0; > + return createPlatformGraphicsContext(BlackBerry::Platform::Graphics::lockBufferDrawable(m_tileRenderingSurface)); > +#endif > +} that wont return anything if !SKIA > Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:175 > + // Create the m_visibleTileBuffer. do we need these comment? > Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:199 > + // Release the m_visibleTileBuffer. ditto > Source/WebKit/blackberry/WebKitSupport/SurfacePool.cpp:205 > + // Release the backbuffer. ditto > Source/WebKit/blackberry/WebKitSupport/SurfacePool.h:87 > +#if USE(SKIA) maybe we should just drop the SKIA condition completely?
Rob Buis
Comment 10 2012-02-10 07:20:33 PST
Created attachment 126513 [details] Patch
Rob Buis
Comment 11 2012-02-10 07:43:35 PST
Landed in r107401.
Rob Buis
Comment 12 2012-02-10 11:23:10 PST
Reopening to attach new patch.
Rob Buis
Comment 13 2012-02-10 11:23:14 PST
Created attachment 126542 [details] Patch
Rob Buis
Comment 14 2012-02-10 11:59:52 PST
Created attachment 126546 [details] Patch
Rob Buis
Comment 15 2012-02-10 12:46:19 PST
Landed in r107426.
Note You need to log in before you can comment on or make changes to this bug.