Bug 78466

Summary: Add [JSCustomToJSObject] IDL attribute to interfaces that have custom toJS() but do not have custom toV8()
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-02-12 23:56:38 PST
The goal is to remove hard-coding in HasCustomToV8Implementation() in CodeGeneratorV8.pm, in the following steps: (1) Add [V8CustomToJSObject] to interfaces which have custom toV8() but do not have custom toJS(). (2) Replace [JSCustomToJS] with [JSCustomToJSObject] for interfaces which have custom toJS() but do not have custom toV8(). (3) Replace [JSCustomToJS] with [CustomToJSObject] for interfaces which have custom toV8() and toJS(). (4) Remove HasCustomToV8Implementation() from CodeGeneratorV8.pm. In this bug we fixes (2).
Attachments
Patch (5.24 KB, patch)
2012-02-13 00:02 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-13 00:02:45 PST
Created attachment 126728 [details] Patch
Kentaro Hara
Comment 2 2012-02-13 00:11:55 PST
BTW, I noticed the hard-coding had been buggy...:-) return 1 if $interfaceName eq "DOMStringMap"; return 1 if $interfaceName eq "DOMTokenList"; ...; return 0 if $interfaceName eq "DOMStringMap"; return 0 if $interfaceName eq "DOMTokenList"; http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm&exact_package=chromium&q=codegeneratorv8.pm&type=cs&l=3136
Adam Barth
Comment 3 2012-02-13 00:16:34 PST
> BTW, I noticed the hard-coding had been buggy...:-) I'm not surprised. :)
WebKit Review Bot
Comment 4 2012-02-13 02:24:42 PST
Comment on attachment 126728 [details] Patch Clearing flags on attachment: 126728 Committed r107553: <http://trac.webkit.org/changeset/107553>
WebKit Review Bot
Comment 5 2012-02-13 02:24:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.