Bug 78874

Summary: Rename [CheckDomainSecurity] to [CheckSecurity]
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77393    
Attachments:
Description Flags
Patch
none
Patch none

Kentaro Hara
Reported 2012-02-16 21:38:31 PST
For naming consistency with [CheckAccessToNode], we can rename the following IDL attributes: [CheckDomainSecurity] => [CheckAccessToFrame] [DoNotCheckDomainSecurity] => [DoNotCheckAccessToFrame] [DoNotCheckDomainSecurityOnGetter] => [DoNotCheckAccessToFrameOnGetter] [DoNotCheckDomainSecurityOnSetter] => [DoNotCheckAccessToFrameOnSetter] Adam: Would it make sense? If so, I'll make a patch.
Attachments
Patch (21.58 KB, patch)
2012-02-16 21:40 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (21.23 KB, patch)
2012-02-19 00:30 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-02-16 21:40:20 PST
Created attachment 127517 [details] Patch
Adam Barth
Comment 2 2012-02-17 10:38:08 PST
Comment on attachment 127517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127517&action=review > Source/WebCore/ChangeLog:12 > + - [CheckDomainSecurity] => [CheckAccessToFrame] > + - [DoNotCheckDomainSecurity] => [DoNotCheckAccessToFrame] I'm not super excited about mentioning "frame" here because that's not quite right. We should be checking access to the ScriptExecutionContext (although we don't get that 100% correct yet). How about: CheckAccess DoNotCheckAccess ? > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1694 > push(@implContent, " if (!castedThis->allowsAccessFrom(exec))\n"); For example, |castedThis| might not be a Frame. We're just generally checking access.
Kentaro Hara
Comment 3 2012-02-18 19:46:19 PST
(In reply to comment #2) > > + - [CheckDomainSecurity] => [CheckAccessToFrame] > > + - [DoNotCheckDomainSecurity] => [DoNotCheckAccessToFrame] > > I'm not super excited about mentioning "frame" here because that's not quite right. We should be checking access to the ScriptExecutionContext (although we don't get that 100% correct yet). How about: > > CheckAccess > DoNotCheckAccess Thanks. Then [CheckDomainSecurity] might be better than [CheckAccess] in that it is clear that it is checking domain security. Instead, how about renaming [CheckAccessToNode] to [CheckDomainSecurityForNode]?
Adam Barth
Comment 4 2012-02-19 00:19:52 PST
> Instead, how about renaming [CheckAccessToNode] to [CheckDomainSecurityForNode]? The problem is that "domain security" isn't a term that's used elsewhere. We usually call it the same-origin policy... How about just [CheckSecurity] or [CheckSameOriginPolicy]? The name [CheckSecurityForNode] makes sense and seems better than [CheckDomainSecurityForNode] or [CheckSameOriginPolicyForNode]...
Kentaro Hara
Comment 5 2012-02-19 00:30:22 PST
Created attachment 127731 [details] Patch
Kentaro Hara
Comment 6 2012-02-19 00:40:08 PST
(In reply to comment #4) > How about just [CheckSecurity] or [CheckSameOriginPolicy]? The name [CheckSecurityForNode] makes sense and seems better than [CheckDomainSecurityForNode] or [CheckSameOriginPolicyForNode]... Sounds good! I uploaded patches: [*CheckDomainSecurity*] => [*CheckSecurity*] : this patch [CheckAccessToNode] => [CheckSecurityForNode] : bug 78991
WebKit Review Bot
Comment 7 2012-02-19 15:47:28 PST
Comment on attachment 127731 [details] Patch Clearing flags on attachment: 127731 Committed r108201: <http://trac.webkit.org/changeset/108201>
WebKit Review Bot
Comment 8 2012-02-19 15:47:34 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.